Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 82ce6c0dd7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| let depth = 0; | ||
|
|
||
| for (const line of lines) { | ||
| const trimmed = line.trim(); |
There was a problem hiding this comment.
MarkdownRenderer now calls trim() on every input line before parsing. Any captured prompt that uses leading whitespace for structure, such as nested bullets or indented code blocks in the AGENTS/INSTRUCTIONS payloads we already fixture in tests/fixtures/protocols/openai-responses/request.json, loses that hierarchy here. Because SystemView renders those prompts through this component, the app can show materially different instructions than the model actually received.
Useful? React with 👍 / 👎.
| dist/*.exe | ||
| dist/*.exe.blockmap | ||
| dist/latest.yml |
There was a problem hiding this comment.
This workflow now publishes Windows updater artifacts (latest.yml and blockmaps), but src/main/update/update-service.ts still hard-codes supported = platform === "darwin" && isPackaged, and src/shared/update.ts still tells non-macOS users updates are unsupported. For every packaged Windows build produced here, the Settings update flow will still no-op and display the macOS-only message, so the new release metadata cannot actually be consumed in-app.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e3da2c05f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| nsis: | ||
| oneClick: false | ||
| allowToChangeInstallationDirectory: true | ||
| deleteAppDataOnUninstall: true |
There was a problem hiding this comment.
Setting nsis.deleteAppDataOnUninstall to true makes the Windows uninstaller remove the same userData directory that src/main/index.ts passes into AppBootstrap, where src/main/bootstrap/app-bootstrap.ts stores profiles.json and agent-trace.db. In practice, a routine uninstall/reinstall of a broken build will now wipe every saved profile and captured trace for Windows users, which is a destructive regression for the new release path.
Useful? React with 👍 / 👎.
1 participant
No description provided.