Conversation
added 6 commits
January 14, 2017 20:50
ghost
self-assigned this
Current coverage is 99.08% (diff: 96.55%)@@ master #37 diff @@
==========================================
Files 5 5
Lines 134 109 -25
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 128 108 -20
+ Misses 6 1 -5
Partials 0 0
|
Author
|
100% codecoverage! 👍 |
Owner
|
@rjrhaverkamp sorry for delayed reply, on a holiday right now , Will be back on 17th jan, lets discuss it then. |
Author
|
Hi @dvopsway ofcourse, it still needs a lot of work and I am thinking about new features etc. Have a nice vacation! |
Owner
|
@rjrhaverkamp would you like to merge this right now, or should we merge this after enhancements. |
Author
|
No, we should defined not merge this yet. I removed a lot of features from it, I want those features back before merging :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is some basic work on #16. It completely removes password support but the code is a lot cleaner now.
Needs a lot more work.