Fix Division By Zero Warning (PHP7 compatibility)#468
Open
tremlin wants to merge 1 commit intodweeves:masterfrom
Open
Fix Division By Zero Warning (PHP7 compatibility)#468tremlin wants to merge 1 commit intodweeves:masterfrom
tremlin wants to merge 1 commit intodweeves:masterfrom
Conversation
Author
|
I haven't tested if this fix is still needed after the latest refactoring of the product import engine. |
Collaborator
|
this is not the best way to fix it. The root cause is a bug in the around line 936 there is And because "step" property is set to empty string and The correct solution for the issue is to fix getProp to return default value (0.5 in this case) when property is an empty string. |
|
This is a fix for this issue: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our installation magmi didn't work with PHP7 because of a divison by zero error. Calculation mod 0 is no longer supported by PHP7 (only a warning in PHP5). This change prevents this error.