Allow for value translation with select/multiselect attributes when is_configurable=0 and scope is global#556
Open
thedotwriter wants to merge 2 commits intodweeves:masterfrom
Open
Allow for value translation with select/multiselect attributes when is_configurable=0 and scope is global#556thedotwriter wants to merge 2 commits intodweeves:masterfrom
thedotwriter wants to merge 2 commits intodweeves:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Dweeves,
I need to be able to translate values for select attributes which are "global" but are not set to be configurable attributes. That's not possible at the moment based on the current logic.
I've read what you've said on #358 about why you choose to force store scope for configurable attributes, but I think you've got to do it not only for configurable attributes but for all select/multiselect attributes in the global scope.
I've made the change and it works. Please have a look when you've got time.
Cheers