50. Pow(x, n)#45
Open
dxxsxsxkx wants to merge 1 commit into1011_capacity_to_ship_packages_within_d_daysfrom
Open
50. Pow(x, n)#45dxxsxsxkx wants to merge 1 commit into1011_capacity_to_ship_packages_within_d_daysfrom
dxxsxsxkx wants to merge 1 commit into1011_capacity_to_ship_packages_within_d_daysfrom
Conversation
nodchip
reviewed
Mar 6, 2026
| long_abs_n /= 2; | ||
| } | ||
|
|
||
| if (n < 0) { |
There was a problem hiding this comment.
自分は n < 0 の場合を関数の上のほうで処理し、 std::abs() を消すほうが好きですが、好みの範囲だと思います。
mamo3gr
reviewed
Mar 17, 2026
| } | ||
|
|
||
| int64_t long_n = n; | ||
| int64_t long_abs_n = std::abs(long_n); |
There was a problem hiding this comment.
C++に詳しくないのですが、long_n はもう使わないので、absを取るときにキャストするのではどうでしょうか。また、int64_t にしなければならない背景をコメントしておくとよいと思いました。
Suggested change
| int64_t long_abs_n = std::abs(long_n); | |
| int64_t abs_n = std::abs(static_cast<int64_t>(long_n)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題
https://leetcode.com/problems/powx-n/
次の問題
779. Kth Symbol in Grammer