3 longest substring without repeating characters#48
Open
dxxsxsxkx wants to merge 2 commits into776_split_bstfrom
Open
3 longest substring without repeating characters#48dxxsxsxkx wants to merge 2 commits into776_split_bstfrom
dxxsxsxkx wants to merge 2 commits into776_split_bstfrom
Conversation
mamo3gr
reviewed
Mar 19, 2026
| int max_length = 0; | ||
|
|
||
| for (int right = 0; right < s.size(); ++right) { | ||
| while (characters.contains(s[right])) { |
There was a problem hiding this comment.
countよりcontainsの方が分かりやすいですね。細かいところも改善されていて素晴らしいと思いました。
mamo3gr
reviewed
Mar 19, 2026
| class Solution { | ||
| public: | ||
| int lengthOfLongestSubstring(std::string s) { | ||
| std::unordered_set<char> characters; |
There was a problem hiding this comment.
この短さなら問題ないのですが、どちらかというと character というより seen のような情報を名前に乗せたいと思いました。character なのは <char> で分かりますし。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題
https://leetcode.com/problems/longest-substring-without-repeating-characters/description/
次の問題
209. Minimum Size Subarray Sum