Fix SS6 consistency issues #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update PHP requirement to ^8.1 (standard for SS6 modules) - Update silverstripe/blog to ^5.1 (consistent with main installer) - Use stable silverstripe/widgets ^3.0 instead of fork - Add branch-alias to dev-master
There was a problem hiding this comment.
Pull Request Overview
This PR ensures consistency with SilverStripe 6 standards across Dynamic modules by aligning dependency versions and PHP requirements. It follows established SS6 upgrade patterns from other Dynamic modules to maintain ecosystem-wide compatibility.
Key changes:
- Relaxed PHP requirement from ^8.3 to ^8.1 for broader compatibility
- Updated silverstripe/blog to ^5.1 and silverstripe/widgets to stable ^3.0
- Removed custom Git repository in favor of stable package releases
- Added branch-alias configuration for proper version management
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #50 to ensure SS6 consistency across all Dynamic modules.
Changes
^8.1(standard for all SS6 modules for maximum compatibility)silverstripe/blogto^5.1(consistent with main installer)silverstripe/widgets ^3.0instead of forkNotes
This aligns with the SS6 upgrade patterns established in other Dynamic modules and ensures consistency across the codebase.