-
Notifications
You must be signed in to change notification settings - Fork 15
Mid-Sized Rewrite of APIs + Devcontainer + Docs Fixes #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…upon the non-existence of Firedrake.
…the foreign function interface.
… lp/bug-hunting Merge quick changes to the remote into the working branch.
❌ Deploy Preview for hydrogym failed.
|
|
Presently at 677 mypy errors. To be brought down to 0 for the merge. |
…d like any other package from PyPi.
❌ Deploy Preview for hydrogym failed.
|
|
Mypy to be replaced in favor of PyreFly for a better developer experience, and better IDE integration. |
|
hi @ludgerpaehler , do you need help on this PR? Since the publication of your paper at L4DC 2025, it would indeed be nice to have the intermediate PRs (each marking an RL-controlled env which produces the RL loss curves) mentioned in #197 (comment) merged for reproducibility reasons. @ludgerpaehler Best, |
|
Hey, just finishing off a paper today and then returning to this PR. There's a number of divergent branches, the unification of which is non-trivial so it might take a couple of days of work to get this realigned. - Ludger |
Bumps version to 0.1.3.0 in light of the changes below:
pyproject.tomlrllibi.e.pip install "hydrogym[rllib]"installs the required additional dependencies now to run
rllibwith HydroGym out of the box.pip install -e .or
pip install ".[rllib]"pip.tryconstruct to gracefully return an error to the user in case Firedrake is not found in the current environment, but needed by HydroGym. To give an example of the construct:colabfolder, in which they can still be launched with Jupyter, but going beyond the previous state, can be auto-launched into Google Colab using the groundwork laid by FEM-on-Colab.