Fix reader data saving #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saving data for ePub File is fixed by updating the base path take as reference.
This was referenced Jan 26, 2022
Saving data for ePub File is fixed by updating the base path taken as reference.
Move the loading of the 'pdf.worker.js' file from ready.js to pdfreader.php
Author
|
This first fix is about the PDF reader. I tested this fix with :
Does it this PR fix anything for other PDF users ? |
Saving data for ePub File is fixed by updating the base path taken as reference.
Open
rounakdatta
reviewed
Mar 15, 2022
templates/pdfreader.php
Outdated
|
|
||
| <html dir="ltr"> | ||
| <head class="session" data-nonce='<?php p($nonce);?>' data-downloadlink='<?php print_unescaped($downloadLink);?>' data-fileid='<?php print_unescaped($fileId);?>' data-filetype='<?php print_unescaped($fileType);?>' data-filename='<?php print_unescaped($fileName);?>' data-version='<?php print_unescaped($version);?>' data-basepath='<?php p($urlGenerator->linkTo("epubreader",""));?>' data-scope='<?php print_unescaped($scope);?>' data-cursor='<?php print_unescaped($cursor);?>' data-defaults='<?php print_unescaped($defaults);?>' data-preferences='<?php print_unescaped($preferences);?>' data-metadata='<?php print_unescaped($metadata);?>' data-annotations='<?php print_unescaped($annotations);?>'> | ||
| <head class="session" data-nonce='<?php p($nonce);?>' data-downloadlink='<?php print_unescaped($downloadLink);?>' data-fileid='<?php print_unescaped($fileId);?>' data-filetype='<?php print_unescaped($fileType);?>' data-filename='<?php print_unescaped($fileName);?>' data-version='<?php print_unescaped($version);?>' data-basepath='<?php p($urlGenerator->linkToRoute('epubreader.page.showReader'));?>' data-scope='<?php print_unescaped($scope);?>' data-cursor='<?php print_unescaped($cursor);?>' data-defaults='<?php print_unescaped($defaults);?>' data-preferences='<?php print_unescaped($preferences);?>' data-metadata='<?php print_unescaped($metadata);?>' data-annotations='<?php print_unescaped($annotations);?>'> |
There was a problem hiding this comment.
@sysadminstory can you explain this change? Will linkToRoute produce apps/epubreader instead of custom_apps/epubreader?
Author
There was a problem hiding this comment.
I have read linkTo was deprecated, so I changed it to a non deprecated function.
To be honest, I'm totally not sure about what's wrong and what's right here !
Static files (like css, js, ...) are now loaded using the 'data-staticpath' parameter, that was added to every template. Static files must be loaded using the real physical URL (un the "customapps" folder if used) instead of the dynamic files, that must be loaded using the index.php file (hidden if the URL rewriting is activated)
sysadminstory
force-pushed
the
fix-saving-data
branch
from
c777a4b to
cd18e33
Compare
… into fix-saving-data
|
@sysadminstory Is anything missing for merging this pull request? 🙏 |
devnoname120
pushed a commit
to devnoname120/epubviewer
that referenced
this pull request
Jul 30, 2023
Original PR: e-alfred/epubreader#42 Saving data is fixed by updating the base path taken as reference.
Author
Well, on my point of view, no, but the owner of this repo seems to be inactive :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress fix for the "not saving" anything #33 #29
This first fix is about the epub reader.
I tested this fix with :
Does it this PR fix anything for other epub users ?