fix: recover shorthand CSS properties containing var() references#38
Draft
fix: recover shorthand CSS properties containing var() references#38
Conversation
When a CSS shorthand (e.g. border-radius) contains var() references, browsers list longhand names in style[i] but return empty strings for getPropertyValue() on each longhand. The previous rollup loop walked arbitrary dash segments instead of the CSS shorthand hierarchy, causing these properties to be silently dropped from snapshots. Replace the rollup loop with a two-pass approach: 1. First pass iterates style[i] as before, tracking longhands with empty values in a Set instead of attempting dash-stripping 2. Second pass (only when empty longhands exist) parses style.cssText with a character-by-character parser that handles nested parentheses (e.g. var(--x, calc(100% - 20px))) to recover shorthand declarations Also strips !important suffixes from cssText values since priority is handled separately via getPropertyPriority().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was playing with adding this to evo-web and ran into some issues.
When a CSS shorthand (e.g. border-radius) contains var() references, browsers list longhand names in style[i] but return empty strings for getPropertyValue() on each longhand. The previous rollup loop walked arbitrary dash segments instead of the CSS shorthand hierarchy, causing these properties to be silently dropped from snapshots.
Replace the rollup loop with a two-pass approach:
Also strips !important suffixes from cssText values since priority is handled separately via getPropertyPriority().