Get rid of the docker dependency #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 23, 2017 16:20
Uses a temporary working directory for elsepa, making it possible to run multiple instances in parallel. Does require the modified version (github.com/eScatter/elsepa) of elsepa, to take the ELSEPA_DATA environment variable.
Contributor
|
Consider installing Elsepa in ~/.local, or /usr/local, and have Python figure out where it is by searching $PATH (using |
added 2 commits
November 24, 2017 10:53
Forgot the most important change in my previous commit...
Author
|
Good points! I added an "install" target to the ELSEPA makefile, which installs to /usr/local by default and asks the user to set the ELSEPA_DATA environment variable. Pyelsepa now uses PATH and ELSEPA_DATA by default, but this can be overridden. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the manwhile, we start to depend on the modified version of ELSEPA taking the ELSEPA_DATA environment variable.
The new elscata() function now takes paths to the elscata binary and the data directory. They default to
/opt/elsepaand/opt/elsepa/data, respectively. Is this a sensible default? Any alternative ideas for making the installation procedure more foolproof?