Skip to content

Conversation

@anesheret
Copy link

* Ubuntu 20.04.6 LTS - compatibility
* Using `cloud-localds` - as described in cloud-init documentation
* `virsh` - auto remove all associated storage volumes

    * Ubuntu 20.04.6 LTS - compatibility
    * Using `cloud-localds` - as described in cloud-init documentation
    * `virsh` - auto remove all associated storage volumes
Copy link

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Using cloud-localds - as described in cloud-init documentation

But why?

cloud-localds is a wrapper around genisoimage, and cloud-utils isn't shipped to as many distros as genisoimage. The only benefit to cloud-localds, as I see it, is that it has a simpler command line invocation, but for a script like this that benefit is lost.

Also, information in the commit message about how virt-install fails and which version the change was made in would be valuable for reviewers and future users of this script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants