Allow specifying a custom devmapper snapshot device on snapshot boot #3
Conversation
amohoste
changed the title
amohoste
force-pushed
the
v0.25_reference_custom_snap
branch
2 times, most recently
from
5e5df1a to
e322467
Compare
ustiugov
left a comment
ustiugov
left a comment
There was a problem hiding this comment.
I believe that there are quite a few unnecessary changes in this PR. please see my comments and revert the changes that can be avoided. The reason for this is that updating the fork is way simpler if our changes are minimal as compared to upstream.
amohoste
force-pushed
the
v0.25_reference_custom_snap
branch
from
e322467 to
9ea5ae5
Compare
|
Regarding the comments, I completely undid the commit introducing the transport_reset_event function, however I agree temporarily commenting the place where it is invoked is a better approach. That way we can reintroduce that function call when someone looks into how to fix the agent becoming unavailable. I have now commented out the place where the transport_reset_event function is invoked. |
ustiugov
left a comment
ustiugov
left a comment
There was a problem hiding this comment.
few more minor tweaks please
amohoste
force-pushed
the
v0.25_reference_custom_snap
branch
2 times, most recently
from
7f68758 to
d824d36
Compare
Signed-off-by: Amory Hoste <amory.hoste@gmail.com>
amohoste
force-pushed
the
v0.25_reference_custom_snap
branch
from
d824d36 to
5deb8a6
Compare
|
lgtm |
amohoste
force-pushed
the
v0.25_reference_custom_snap
branch
from
89843c4 to
52890e5
Compare
Signed-off-by: Amory Hoste <amory.hoste@gmail.com>
amohoste
force-pushed
the
v0.25_reference_custom_snap
branch
from
52890e5 to
9b375b6
Compare
|
|
||
| # Development container image (without tag) | ||
| DEVCTR_IMAGE_NO_TAG="docker.io/vhiveease/fcuvm_dev" | ||
| DEVCTR_IMAGE_NO_TAG="docker.io/amohoste/fcuvm_dev" |
There was a problem hiding this comment.
please fix, update the build image on vhiveease if necessary
| # Development container tag | ||
| #DEVCTR_IMAGE_TAG="v30" | ||
| DEVCTR_IMAGE_TAG="v16_upf" | ||
| DEVCTR_IMAGE_TAG="v30" |
There was a problem hiding this comment.
| DEVCTR_IMAGE_TAG="v30" | |
| DEVCTR_IMAGE_TAG="v30_upf" |
2 participants
This PR adds the functionality to specify a custom devmapper snapshot block device that contains the container root filesystem contents. The content of this block device must be the exact filesystem contents present at the time the corresponding Firecracker snapshot was taken. Allowing to specify a custom snapshot block devices allows us to more efficiently manage snapshots along with the possibility to boot from a remote snapshot. Additionally, the transport_reset event introduced in v0.25.0 was also removed since this interfered with the ability to restore a snapshot due to the FC agent becoming unreachable.