Skip to content

Add id to bsCollapsePanel#133

Open
warnes wants to merge 8 commits intoebailey78:shinyBS3from
warnes:bs-collapse-panel-id
Open

Add id to bsCollapsePanel#133
warnes wants to merge 8 commits intoebailey78:shinyBS3from
warnes:bs-collapse-panel-id

Conversation

@warnes
Copy link

@warnes warnes commented Jan 6, 2021

  • Adds optional id tag to bsColllapsePanel
  • Adds bsCollapseButton and bsCollapseLink functions to generate buttons/links that toggle a bsCollapsePanel.
  • Update Collapse example to use these.

Resolves #132

(Also adds renv environment for development convenience. I'll be glad to drop it if you prefer.)

@warnes
Copy link
Author

warnes commented Jan 6, 2021

To maximize backwards compatibility, the current parameter list for bsCollapsePanel and bsCollapseLink is:

function(title, ..., id, value = title, style = NULL)

with id being optional.

It would better match the usual shiny pattern to put id first, and make both id and title required, thus:

function(id, title, ..., value=id, style=NULL)

warnes added 3 commits January 7, 2021 02:16
…pseLink`.

* Fix issue with `bsCollapseLink` generating `href` attributes with an extra "# ".
* Minor formatting improvement to Collapse demo.
…pseLink`.

* Fix issue with `bsCollapseLink` generating `href` attributes with an extra "# ".
* Minor formatting improvement to Collapse demo.
Merge branch 'bs-collapse-panel-id' of github.com:warnes/shinyBS into bs-collapse-panel-id

# Conflicts:
#	R/bsCollapseButton.R
#	man/bsCollapseButton.Rd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FR: Allow specification of id tag in bsCollapsePanel

1 participant