Fixing iss38 (conditionalPanel within bsCollapsePanel).#68
Open
mattflor wants to merge 1 commit intoebailey78:shinyBS3from
Open
Fixing iss38 (conditionalPanel within bsCollapsePanel).#68mattflor wants to merge 1 commit intoebailey78:shinyBS3from
mattflor wants to merge 1 commit intoebailey78:shinyBS3from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully, this fixes issue #38. I am not sure though whether this is just tinkering with the symptoms.
If
conditionalPanels are nested withinbsCollapsePanels then somehow thesbs-valuedata array of the parentbsCollapsemay contain multiple entries for the samebsCollapsePanel.Basically, all this fix does is the following:
bsCollapsePanelhide events: remove ALL entries of thebsCollapsePanelto hide from thebsCollapse'ssbs-valuearray, using the new functionremoveA()bsCollapsePanelshow events: only push thebsCollapsePanelto thesbs-valuearray if it is not in there alreadyWhat I was not able to find out is why multiple entries show up at all.