Creating better tooltips/popovers for elements with sub-choices. #70
Open
RohdeK wants to merge 15 commits intoebailey78:shinyBS3from
Open
Creating better tooltips/popovers for elements with sub-choices. #70RohdeK wants to merge 15 commits intoebailey78:shinyBS3from
RohdeK wants to merge 15 commits intoebailey78:shinyBS3from
Conversation
Add new features, that add specific popovers to selectize lists.
Add new features, that add specific popovers to group inputs.
Added server side tooltip/popover creation.
Added remove popover/tooltip functionality.
Added updateSelectize custom message handler for server sided creation of popovers and tooltips on selectize Elements.
Added observer dictionary to created tabs and observers.
Changed selectize handler to also disconnect observers.
Included server sided tooltip/popover updates.
Added GroupInput server side message handler.
|
Hi, is it possible to use this feature? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, my name is Konstantin and I recently answered to an issue on stackoverflow here, from where I got the idea to propose a pull request.
There, the user requested to add tooltips/popovers from shinyBS onto singular choices of
radioButtonsand not only the wholeradioButtonelement. Now, I got much further into shinyBS and wrote a small extension, which adds those features for groupInputs (that isradioButtonandcheckboxGroup) andselectizeInputs.The main aim was to create tooltips/popovers to a certain
choiceof such an element. In effect and design, the resulting functions remain very similar to the originalbsPopover/bsTooltipfunctions. They just take an additional value (the specific choice which should be highlighted) and differ mostly in the JavaScript selection algorithm. I tried hard to match the language and style of the work you guys have done so far.Also, I tried/managed to supply both the ui-sided as well as the server-sided versions to create and delete tooltips/popovers, just like the regular
bsTooltip/bsPopover.While
groupInputTooltip/-Popoveris very straight-forward,selectizeTooltip/-Popoverneeds some additional machinery, using observers, to re-enact tooltips/popovers whenever the DOM is changing. Those observers have to be stored in a collection, such that they can be disconnected, if the tooltip/popover is to be removed.I already did a lot of testing on the way and everything has been working well. There should be no conflict with the rest of the package. I'd appreciate if you'd try out my functions and see if this is worth including into your package.
Best regards,
Konstantin Rohde