tagsoup will insert <html><head>..</head></html> around template pieces ... #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es that contain <link> elements
If *template-path* is nil, the template path will be rooted at the top of the web resource path.
Author
|
Ups, I didn't intend for the "allow template-path to be nil patch to be included in this pull request, I think they are both appropriate changes, however. |
Author
|
And the commit comment is pretty scrambled. It turns out that if you have a template file that looks like this: <link rel="stylesheet" href=".."> tag soup will wrap it with <html><head> and </head></html>, instead of This patch makes the processing of included templates work in either case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tagsoup will insert <html><head>..</head></html> around template pieces
that contain <link> elements, so it's necessary for the html-body function
to be able to handle that.