Bug fix and change filterMany to put predicates into JOIN clause, Fix for #3626 #3707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbygrave
changed the title
PromanSEW
added a commit
to PromanSEW/play-ebean
that referenced
this pull request
Nov 23, 2025
Important fix: ebean-orm/ebean#3707 Please release new version, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix for an issue raised at #3626 (comment)
The fix/change is for when filterMany predicates get included into the main query, for those predicates to be included in the JOIN clause rather than the WHERE clause. This simplifies the how filterMany works when it is included in the main query, when it is NOT included in the main query but instead part of a separate query (effectively a fetchQuery) then the predicates are included in there WHERE clause of the secondary query.
Reference (bit of a sordid history here):
Original inline support - #2222 (version 12.9.0)
Related Bug 1 - #3453 (version 14.5.2)
Related Bug 2 - #3625 (version 16.0.0)
Issue prompting this change: #3626 (comment)