Skip to content

Fix compile-time warnings when compiling with MSVC and /W4 #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jfriesne wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix compile-time warnings when compiling with MSVC and /W4 #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6210702
Modified Bw64Reader::seek() to take an int64_t offset argument instea…
jfriesne Mar 8, 2026
d5d6fe7
Tweaked the parser code to avoid some compile-time warnings when comp…
jfriesne Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/bw64/chunks.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ namespace bw64 {
formatTag_ = formatTag;
channelCount_ = channels;
sampleRate_ = sampleRate;
bitsPerSample_ = bitDepth;
bitsPerSample_ = (uint16_t) bitDepth;
extraData_ = extraData;

// validation
Expand Down
10 changes: 5 additions & 5 deletions include/bw64/parser.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,11 +214,11 @@ namespace bw64 {

std::map<uint32_t, uint64_t> table;
for (uint32_t i = 0; i < tableLength; ++i) {
uint32_t id;
uint64_t size;
utils::readValue(stream, id);
utils::readValue(stream, size);
table[id] = size;
uint32_t readID;
uint64_t readSize;
utils::readValue(stream, readID);
utils::readValue(stream, readSize);
table[readID] = readSize;
}
// skip junk data
stream.seekg(size - minSize, std::ios::cur);
Expand Down
2 changes: 1 addition & 1 deletion include/bw64/reader.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ namespace bw64 {
/**
* @brief Seek a frame position in the DataChunk
*/
void seek(int32_t offset, std::ios_base::seekdir way = std::ios::beg) {
void seek(int64_t offset, std::ios_base::seekdir way = std::ios::beg) {
auto numberOfFramesInt = utils::safeCast<int64_t>(numberOfFrames());

// where to seek relative to according to way
Expand Down