Add @shopify/restyle
#175
Add @shopify/restyle
#175
Conversation
| module.exports = { | ||
| root: true, | ||
| extends: ['plugin:echobind/react-native'], | ||
| rules: { |
There was a problem hiding this comment.
These were both causing issues for me, not sure if we should add them to the plugin or leave them here
| @@ -0,0 +1,23 @@ | |||
| name: PR Verify | |||
There was a problem hiding this comment.
I like to have a check like this in all my fresh projects but I can remove this if we don't want it in the template
| return ( | ||
| <Stack.Navigator headerMode="none" initialRouteName="Intro"> | ||
| <Stack.Screen name="Intro" component={IntroScreen} /> | ||
| <Stack.Screen name="Onboard" component={OnboardingNav} /> |
There was a problem hiding this comment.
This wasn't being used anywhere but not sure if there was another reason it was in here
| * First screen a logged out user sees, welcoming them to the app. | ||
| */ | ||
| export const IntroScreen: FC<NavigationScreenProps> = ({ navigation }) => { | ||
| export const IntroScreen: FC<{ navigation: any }> = ({ navigation }) => { |
There was a problem hiding this comment.
import { NavigationScreenProps } from 'react-navigation'; was lighting up because react-navigation isn't a package anymore. I haven't figured out yet what this type should be, but I also plan to come back and refactor this to use a hook instead of the screen props
| @@ -0,0 +1,24 @@ | |||
| name: PR Verify | |||
There was a problem hiding this comment.
This will add safety to the template repository to ensure we aren't introducing changes that will cause this to fail in an out of the box app. I can remove this as well or move it to circle CI
Description
@shopify/restylefor component themingTo Do
Screenshots