Fixes #90 SSL Context verification purpose with client SSL authentication #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te a client socket with a PROTOCOL_TLS_SERVER context
Contributor
|
Could you add a note in |
jamesoc-eiq
approved these changes
Jan 28, 2025
jamesoc-eiq
left a comment
jamesoc-eiq
left a comment
There was a problem hiding this comment.
Looks good.
Key context to the issue can be seen here:
https://github.com/python/cpython/blob/4d0d24f6e3dff2864007c3cfd1cf7d49c6ee5317/Lib/ssl.py#L696
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #90 SSL Context verification purpose with client SSL authentication
Issue
When making HTTPS requests, the following error occurred:
This issue was caused by an incorrect SSL context configuration, where
ssl.Purpose.CLIENT_AUTHwas used instead ofssl.Purpose.SERVER_AUTH.Root Cause
ssl.Purpose.CLIENT_AUTHis intended for servers verifying client certificates, not for clients verifying a server’s certificate.ssl.Purpose.SERVER_AUTH.Solution
Updated the SSL context creation to use
ssl.Purpose.SERVER_AUTH: