Skip to content

Fix bug in apply_workload regarding sending an empty mask#65

Merged
GabyUnalaq merged 1 commit intomainfrom
fix_apply_workload_empty_masks
Mar 12, 2026
Merged

Fix bug in apply_workload regarding sending an empty mask#65
GabyUnalaq merged 1 commit intomainfrom
fix_apply_workload_empty_masks

Conversation

@GabyUnalaq
Copy link
Contributor

Description

After fetching a workload through the get_workload function, it has no masks. This is to allow the user to change specific fields in the fetched workload, with the masks reflecting only those fields.
If the user applies a workload without changing any fields, the system would overwrite the whole system, keeping only this workload, which is not the intended functionality.

This PR fixes the issue.

Definition of Done

The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.

@GabyUnalaq GabyUnalaq self-assigned this Mar 12, 2026
@GabyUnalaq GabyUnalaq added the bug Something isn't working. Issue will appear in the change log "Bug Fixes" label Mar 12, 2026
Copy link
Contributor

@krucod3 krucod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@GabyUnalaq GabyUnalaq merged commit 8261678 into main Mar 12, 2026
11 checks passed
@GabyUnalaq GabyUnalaq deleted the fix_apply_workload_empty_masks branch March 12, 2026 16:17
@GabyUnalaq GabyUnalaq changed the title Add check for empty masks in apply_workload Fix bug in apply_workload regarding sending an empty mask Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working. Issue will appear in the change log "Bug Fixes"

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants