Improved dependency management #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmatej
commented
Dec 19, 2025
dmatej
commented
- OSGI configuration was too strict and enforced GlassFish devs to hack Metro to allow later versions without a need to release new Metro. That is contraproductive, so the first commit just sets minimal versions without limiting maximum - just for "normal" dependencies, Jakarta Webservices will be still strict.
- Removed webservices-extra. I checked Maven Central and I did not find any publicly visible usage for it except Metro. However I believe Metro should rather use proper dependency management. The removal also means that we don't compile our dependencies any more - that failed using updated grizzly 4.1.0-SNAPSHOT which uses syntax available in Java 17, while we still support just Java 11.
- This PR was tested with GlassFish 8.0.0-SNAPSHOT.
- Metro is released quite rarely while it is still compatible with multiple generations of Jakarta EE. It cannot predict which modules can or cannot be compatible. - Current situation forces ie. GlassFish devs to hacking - repackaging Metro with patched Manifest file to be able to use Metro together with other dependencies which move faster, but are still compatible. - Compatibility should be defined by testing, not by declarations. - Something different is relation with own specs, where we strictly declare which spec version or range we do implement. Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- The module was recompiling dependencies - that is not possible with latest grizzly snapshot as we use older Java. It was also hiding dependencies and in the future could cause issues with JPMS. - This commit was tested with GlassFish 8.0.0-SNAPSHOT and passed. Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- After removal of extra I forgot to add dependencies back Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
arjantijms
approved these changes
Dec 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.