Skip to content

Implement JsonStructureParser.currentEvent() #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jbescos merged 2 commits into from
Nov 12, 2024
Merged

Implement JsonStructureParser.currentEvent() #134

jbescos merged 2 commits into from
Nov 12, 2024

Conversation

@marschall
Copy link
Contributor

@marschall marschall commented Nov 10, 2024

No description provided.

@marschall
Copy link
Contributor Author

marschall commented Nov 10, 2024

If #next() is never called null is returned. It's unclear if this is correct, the spec doesn't say but it's in line with JsonParserImpl#currentEvent().

@jbescos
Update JsonStructureParser.java
48d478e 
Trigger the GH actions
jbescos
jbescos approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@jbescos jbescos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are consistent with JsonParserImpl#currentEvent(). LGTM

@jbescos jbescos merged commit f3bb2d7 into eclipse-ee4j:master Nov 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbescos jbescos jbescos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marschall @jbescos