Make JsonArrayImpl implement RandomAccess #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make JsonArrayImpl implement RandomAccess like EmptyArray.
jbescos
reviewed
Nov 12, 2024
Member
jbescos
left a comment
jbescos
left a comment
There was a problem hiding this comment.
Thank you for this performance PR. Could you update Copyright (c) 2012, 2023 to Copyright (c) 2012, 2024 please?.
Copy-right update
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
JsonArrayImplimplementRandomAccesslikeEmptyArray. This makes various JDK classes prefer index access over iterator access, for exampleCollections#copyorList#spliterator().