Skip to content

feat: Adjust to strict ttl #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
georgemoscu wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Adjust to strict ttl #29

georgemoscu wants to merge 3 commits into from

Conversation

@georgemoscu
Copy link

@georgemoscu georgemoscu commented Aug 2, 2024 •
edited
Loading

Description

  • Adapted to the new strict ttl
  • Changed the structure to a more friendly javascript way, by transforming the unnecessary classes into simple functions
  • rdfModel and store are now globally singletons

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@georgemoscu georgemoscu requested a review from michelu89 August 2, 2024 12:30
@georgemoscu georgemoscu self-assigned this Aug 2, 2024
@georgemoscu georgemoscu force-pushed the feature/RBS-13675-adjust-to-strict-ttl branch 3 times, most recently from 196d5eb to 1b9c98f Compare August 19, 2024 13:50
@georgemoscu
Updated to strict ttl
b9279be 
Modified loaders to work with new infrastructure

Fixed Jest tests

Changed node to version 18
@georgemoscu georgemoscu force-pushed the feature/RBS-13675-adjust-to-strict-ttl branch 2 times, most recently from 874f838 to b9279be Compare August 21, 2024 11:22
@michelu89 michelu89 self-requested a review September 17, 2024 07:17
@georgemoscu georgemoscu changed the title [WIP] Adjust to strict ttl feat: Adjust to strict ttl Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michelu89 michelu89 Awaiting requested review from michelu89

1 more reviewer

@waltersve waltersve waltersve left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@georgemoscu georgemoscu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@georgemoscu @waltersve @michelu89