Validate that no return type is specified for fragments #2058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilkrebs
approved these changes
Oct 29, 2025
msujew
requested changes
Oct 29, 2025
| if (rule.fragment) { | ||
| if (rule.dataType || rule.returnType || rule.inferredType) { | ||
| accept('error', | ||
| "Fragments assign values to the object of the caller, but don't create a new object themselves. Therefore specifying the type of the returned object is not possible.", |
Member
There was a problem hiding this comment.
Suggestion: The validation message is too long IMO.
Suggested change
| "Fragments assign values to the object of the caller, but don't create a new object themselves. Therefore specifying the type of the returned object is not possible.", | |
| "Fragment rules cannot specify a return type.", |
Contributor
There was a problem hiding this comment.
Makes sense, the longer description about why can be found in the documentation if the user requires more details: https://langium.org/docs/reference/grammar-language/#rule-fragments
Contributor
Author
There was a problem hiding this comment.
I just pushed a new commit with the proposed, shorter error message.
msujew
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.