update guava and gson #882
Conversation
Signed-off-by: Christian Dietrich <christian.dietrich.opensource@gmail.com>
|
I assume this update isn't needed for 2025-03? |
|
Depends on how many gsons we want to end up in simrel |
jonahgraham
left a comment
jonahgraham
left a comment
There was a problem hiding this comment.
We don't have dups in SimRel for these at the moment. This change LGTM, but it only affects what we build and publish, it doesn't change our dependencies so won't affect what is in SimRel.
When SimRel / Maven Central has new versions of guava and gson than in our versions gradle file, we can adjust the ranges.
So, if I am not missing anything, I won't do a new release for this change.
|
lets see what m3 will show. |
|
SimRel continues to be ok, we may want to tighten up the version constraints in https://github.com/eclipse-lsp4j/lsp4j/blob/main/gradle/versions.gradle (raise lower bounds to what is in SimRel 2025-12), but I don't seem much advantage to that as it doesn't change what happens in SimRel and
☝️ was incomplete, it only affects what we build and publish in the maven step. It doesn't even affect what we build and test with gradle, which is auto-selected as highest available in maven central that satisfies our version ranges. (In fact I don't quite understand how gradle chooses version to use, because on my machine I see it using guava 33.4.8 instead of 33.5 - do we have a problem with 33.5?) I don't think guava version matters as it affects only generator these days (IIRC) I recommend closing this PR for now, and if desired I can make a new PR that raises lower bounds. |
No description provided.