Skip to content

Fix CT-P1 clang-tidy violations in logger production paths#405

Merged
rolandreichweinbmw merged 1 commit intoeclipse-openbsw:mainfrom
simon-d-bmw:gh-381-ct-p1-logger-prod
Mar 18, 2026
Merged

Fix CT-P1 clang-tidy violations in logger production paths#405
rolandreichweinbmw merged 1 commit intoeclipse-openbsw:mainfrom
simon-d-bmw:gh-381-ct-p1-logger-prod

Conversation

@simon-d-bmw
Copy link
Contributor

Summary

Fix CT-P1 cppcoreguidelines findings in logger production paths.

Closes #381.

Changes

  • Added a brief explanatory comment and file-scoped NOLINTBEGIN/NOLINTEND for cppcoreguidelines-pro-type-vararg around intentional SharedStringWriter::printf usage.
  • No functional behavior changes.

File modified

  • libs/bsw/logger/src/logger/DefaultLoggerCommand.cpp

Validation

  • Scoped CT-P1 clang-tidy (logger src/include): 3 -> 0 findings
  • Logger-focused tests: 23/23 passed
  • treefmt: clean

Add a scoped suppression around SharedStringWriter::printf usage.\nThis keeps behavior unchanged while resolving logger CT-P1 findings.
@rolandreichweinbmw rolandreichweinbmw merged commit c2e895c into eclipse-openbsw:main Mar 18, 2026
166 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rework .clang-tidy ruleset

2 participants