Skip to content

Conversation

@markpatton
Copy link
Contributor

@markpatton markpatton commented Jul 7, 2025

  • Add a notice about NIHMS submissions on the thanks page
  • Adds a new userGuideUrl branding config option which is used on the thanks page.
  • Switch the PMC check on the files step use repositoryKey instead of name
  • Fix the failing external repo component test by removing the check on a font awesome glyph because the glyph gets added asynchonously

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2025

@markpatton markpatton requested review from Copilot and rpoet-jh July 7, 2025 16:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a notice for NIHMS submissions on the thanks page, introduces a new userGuideUrl config option, switches PMC checks to use repositoryKey, and fixes a flaky icon assertion in an external-repo test.

  • Show NIHMS-specific messaging when a submission includes the PMC repository
  • Replace FAQ link with a User Guide link driven by new userGuideUrl config
  • Update PMC checks in both templates and code to use repositoryKey instead of name
  • Remove fragile font-awesome glyph assertion in external-repo test

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/integration/components/external-repo-review-test.js Removed asynchronous FA icon check to stabilize the test
app/templates/thanks.hbs Added NIHMS submission notice inside a loop over submission.repositories and replaced FAQ link with User Guide link
app/routes/thanks.js Injected store service and implemented model hook to include repositories
app/controllers/thanks.js Swapped out faqUrl for the new userGuideUrl from branding config
app/components/workflow-files/index.hbs Changed PMC filtering from repo.name === "PubMed Central" to repo.repositoryKey === "pmc"
Comments suppressed due to low confidence (2)

app/components/workflow-files/index.hbs:3

  • [nitpick] Since the PMC condition was switched to use repositoryKey, ensure existing tests for this component are updated or new tests are added to cover the 'pmc' key path instead of the previous name-based check.
  {{#if (eq repo.repositoryKey "pmc")}}

tests/integration/components/external-repo-review-test.js:26

  • [nitpick] The test description may still imply that an error icon should be present, but the assertion was removed. Consider updating the test title or adding alternative assertions to accurately reflect the component's behavior.
      );

Copy link
Contributor

@rpoet-jh rpoet-jh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tested and saw the new info message on the Thanks page.

@markpatton markpatton merged commit fb4207f into main Jul 7, 2025
5 checks passed
@markpatton markpatton deleted the 1193-nihms-notice branch July 7, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants