Several changes to enhance swt compatibility #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In SWT you can execute JavaScript code in the Browser constructor, in RWT you could not, because the Iframe did not yet exist. Now it flickers into existence and you can execute JavaScript in it. Also-by: Ralf Schlesinger <ralf.schlesinger@robotron.de>
Adapted test so Browser throws WidgetDisposed, when widget is disposed. Also-by: Ralf Schlesinger <ralf.schlesinger@robotron.de>
Also-by: Ralf Schlesinger <ralf.schlesinger@robotron.de>
Also-by: Ralf Schlesinger <ralf.schlesinger@robotron.de>
Also-by: Ralf Schlesinger <ralf.schlesinger@robotron.de>
It was possible to prevent the delivery of dispose event, by overridding notifyListeners, this is not possible in swt. Also-by: Ralf Schlesinger <ralf.schlesinger@robotron.de>
Also-by: Ralf Schlesinger <ralf.schlesinger@robotron.de> Also-by: Rico Scholz <rico.scholz@robotron.de>
adapted tests to new behavior Also-by: Ralf Schlesinger <ralf.schlesinger@robotron.de>
In SWT the buttons are not in the statemask except in MouseUp. Also-by: Ralf Schlesinger <ralf.schlesinger@robotron.de>
SWT does not call getBackground/getForeground/getFont during construction, so RWT should not too. Also-by: Ralf Schlesinger <ralf.schlesinger@robotron.de>
RAP is drawing text on coordinate 0,0 everytime at the top. RCP is stepping down and introduces something like a margin. We set the margins to get in most cases good looking texts. Could be wrong sometimes and off by 1. Also-by: Ralf Schlesinger <ralf.schlesinger@robotron.de> Also-by: Rico Scholz <rico.scholz@robotron.de>
|
Can one of the admins verify this patch? |
Contributor
|
ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should enhance compatibility between using RAP und RCP with the same application
Also-by: Ralf Schlesinger ralf.schlesinger@robotron.de
Also-by: Rico Scholz rico.scholz@robotron.de