add codeowner to inc_nlohmann_json#93
Conversation
|
Thank you for raising a pull request to update the configuration of your GitHub organization. The following conditions need to fulfilled for auto-merging to be available:
Otterdog commands and optionsYou can trigger otterdog actions by commenting on this PR:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
cc @eclipse-score/automotive-score-project-leads @eclipse-score/automotive-score-committers |
| "refs/heads/main" | ||
| ], | ||
| required_pull_request+: default_review_rule, | ||
| bypass_actors+: [ |
There was a problem hiding this comment.
Please use codeowner files
There was a problem hiding this comment.
Sorry, could you please elaborate? I should update the codeowner file in https://github.com/eclipse-score/inc_nlohmann_json first ?
There was a problem hiding this comment.
Do you really need bypass_actors? Or is CODEOWNERS sufficient?
There was a problem hiding this comment.
For the migration of the TSF documentation for the json parsing library from https://github.com/score-json/json into https://github.com/eclipse-score/inc_nlohmann_json, we need someone (for example @4og) who can create a main branch in the target repo with some specific content.
To do that, they need to be able to bypass the default review ruleset for main branch (see https://otterdog.eclipse.org/projects/automotive.score/repos/inc_nlohmann_json#rulesets). Currently, trying to create a main branch leads to "error: GH013: Repository rule violations found for refs/heads/main".
I assume CODEOWNERS is not sufficient to bypass the default review ruleset for main, or?
There was a problem hiding this comment.
Just tested the above by adding the user to CODEOWNERS file: eclipse-score/nlohmann_json#1
Was not sufficient unfortunately.
There was a problem hiding this comment.
No. The develop branch is also needed for the migration. We want to create a new main branch from https://github.com/nlohmann/json/releases/tag/v3.12.0, and then set the main branch as the default.
There was a problem hiding this comment.
That means everytime a new tag is created you want to switch the main to a new tag?
There was a problem hiding this comment.
New releases would be introduced into develop, then merged to main via PR. No "switching" or bypassing of the ruleset in main will be needed after completing the migration.
There was a problem hiding this comment.
- Okay then I would say for one timer its okay. Then please
- Migrate and create a new pull request to remove the bypassing
- Add more committer to the codeowner file (at least two) as maintainers
There was a problem hiding this comment.
Understood, will do. Thanks a lot!
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Can this be merged please? |
|
Please find below the validation of the requested configuration changes: Diff for 082dd6eProject automotive.score[github_id=eclipse-score]
there have been 25 validation infos, enable verbose output to display them.
+ add team[name="codeowner-inc_nlohmann_json"] {
+ description = ""
+ members = [
+ "4og"
+ ],
+ name = "codeowner-inc_nlohmann_json"
+ notifications = true
+ privacy = "visible"
+ skip_members = false
+ skip_non_organization_members = true
+ }
! repo_ruleset[name="main", repository=inc_nlohmann_json] {
! bypass_actors = [
+ "@eclipse-score/codeowner-inc_nlohmann_json"
! ]
! requires_linear_history = false -> true
! }
Plan: 1 to add, 2 to change, 0 to delete. |
|
Warning The current configuration is out-of-sync with the live settings: Diff to live settingsProject automotive.score[github_id=eclipse-score]
there have been 25 validation infos, enable verbose output to display them.
! team[name="cft-orchestration"] {
! members = [
+ "pawelrutkaq"
+ "vinodreddy-g"
! ]
! }
! team[name="cft-persistency"] {
! members = [
+ "arkjedrz"
+ "vinodreddy-g"
! ]
! }
! repository[name="reference_integration"] {
! code_scanning_default_languages = [
- "actions"
! ]
! }
Plan: 0 to add, 3 to change, 0 to delete.Important The current configuration needs to be updated to reflect the live settings otherwise they would be overwritten when this PR gets merged. cc @eclipse-score/eclipsefdn-security cc @eclipse-score/eclipsefdn-releng |
^ |
|
/otterdog merge |
|
@kairoaraujo can you please check the sync? |
|
Caution The changes could not be applied successfully, please check the output: Project automotive.score[github_id=eclipse-score]
there have been 25 validation infos, enable verbose output to display them.
+ add team[name="codeowner-inc_nlohmann_json"] {
+ description = ""
+ members = [
+ "4og"
+ ],
+ name = "codeowner-inc_nlohmann_json"
+ notifications = true
+ privacy = "visible"
+ skip_members = false
+ skip_non_organization_members = true
+ }
! repo_ruleset[name="main", repository=inc_nlohmann_json] {
! bypass_actors = [
+ "@eclipse-score/codeowner-inc_nlohmann_json"
! ]
! requires_linear_history = false -> true
! }
Applying changes:
-
- Error: failed to apply patch: ADD- team[name="codeowner-inc_nlohmann_json"]
- failed to add team 'codeowner-inc_nlohmann_json': {"message":"Resource not accessible by
- integration","documentation_url":"https://docs.github.com/rest/teams/teams#create-a-team","statu…
-
-
- Error: failed to apply patch: CHANGE- repo_ruleset[name="main", repository=inc_nlohmann_json]
- failed retrieving team node id:
- Exception while accessing
- 'http://ghproxy:8888/orgs/eclipse-score/teams/codeowner-inc_nlohmann_json': (status=404,
- body={"message":"Not
- Found","documentation_url":"https://docs.github.com/rest/teams/teams#get-a-team-by-name","status…
-
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00
Done.
Executed plan: 1 added, 2 changed, 0 deleted.cc @eclipse-score/eclipsefdn-security cc @eclipse-score/eclipsefdn-releng |
|
@kairoaraujo, based on the error above, it looks like it didn't work. Can you please check? I'm still getting the rule violation issue when trying to push to inc_nlohmann_json main branch. |
|
@eclipse-score/automotive-score-project-leads @eclipse-score/automotive-score-committers @kairoaraujo |
|
Fixed |
|
/otterdog done |
|
Note The PR has been marked as being completed. |
6 participants
Adding @4og as codeowner and bypass actor to inc_nlohmann_json