Skip to content

Add "#![feature(non_null_from_ref)]" in log fmt lib.rs#62

Closed
paulquiring wants to merge 1 commit intoeclipse-score:mainfrom
etas-contrib:paulquiring/log_fmt-non_null_from_ref
Closed

Add "#![feature(non_null_from_ref)]" in log fmt lib.rs#62
paulquiring wants to merge 1 commit intoeclipse-score:mainfrom
etas-contrib:paulquiring/log_fmt-non_null_from_ref

Conversation

@paulquiring
Copy link
Contributor

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • PR title is short, expressive and meaningful
  • Commits are properly organized
  • Relevant issues are linked in the References section
  • Tests are conducted
  • Unit tests are added No new functionally is added

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #61

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: e6f45308-1907-43ff-9628-cb2247eef47a
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.7.1, but got bazel_skylib@1.8.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_rust', the root module requires module version rules_rust@0.61.0, but got rules_rust@0.67.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.1, but got rules_cc@0.2.14 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version buildifier_prebuilt@7.3.1, but got buildifier_prebuilt@8.2.0.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_docs_as_code', the root module requires module version score_docs_as_code@2.0.2, but got score_docs_as_code@2.2.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (27 packages loaded, 9 targets configured)

Analyzing: target //:license-check (88 packages loaded, 9 targets configured)

Analyzing: target //:license-check (143 packages loaded, 1051 targets configured)

Analyzing: target //:license-check (143 packages loaded, 1051 targets configured)

Analyzing: target //:license-check (152 packages loaded, 2649 targets configured)

Analyzing: target //:license-check (159 packages loaded, 3073 targets configured)

Analyzing: target //:license-check (161 packages loaded, 3099 targets configured)

Analyzing: target //:license-check (164 packages loaded, 3122 targets configured)

Analyzing: target //:license-check (164 packages loaded, 3122 targets configured)

Analyzing: target //:license-check (168 packages loaded, 5256 targets configured)

Analyzing: target //:license-check (194 packages loaded, 5551 targets configured)
[9 / 14] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_tooling+/dash/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local ... (2 actions running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 4 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
Analyzing: target //:license-check (196 packages loaded, 5559 targets configured)
[12 / 14] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
Analyzing: target //:license-check (196 packages loaded, 5559 targets configured)
[12 / 14] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
Analyzing: target //:license-check (196 packages loaded, 5559 targets configured)
[14 / 14] no actions running
Analyzing: target //:license-check (197 packages loaded, 5559 targets configured)
[14 / 14] no actions running
INFO: Analyzed target //:license-check (197 packages loaded, 9893 targets configured).
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 29.242s, Critical Path: 3.53s
INFO: 14 processes: 9 internal, 4 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

The created documentation from the pull request is available at: docu-html

@paulquiring
Copy link
Contributor Author

the feature non_null_from_ref has been stable since 1.89.0 and no longer requires an attribute to enable

@paulquiring paulquiring closed this Feb 6, 2026
@paulquiring paulquiring deleted the paulquiring/log_fmt-non_null_from_ref branch February 6, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: use of unstable library feature non_null_from_ref

1 participant