qnx: added option to use additional command params#73
Merged
AlexanderLanin merged 2 commits intomainfrom Mar 9, 2026
Merged
Conversation
use lockfile error mode by default Signed-off-by: Dan Calavrezo <195309321+dcalavrezo-qorix@users.noreply.github.com>
.github/workflows/qnx-build.yml
Outdated
|
|
||
| echo "Using credential helper at ${CRED_HELPER}" | ||
| bazel build --config ${{ inputs.bazel-config }} --credential_helper=*.qnx.com="${CRED_HELPER}" -- \ | ||
| bazel build --config ${{ inputs.bazel-config }} --lockfile_mode=error \ |
Member
There was a problem hiding this comment.
is adding --lockfile_mode=error fully backwards compatible for all users?
Contributor
Author
There was a problem hiding this comment.
no, it's an enforcement
Contributor
Author
There was a problem hiding this comment.
@AlexanderLanin I'll make it backwards compatible, if you want
then I'll have to modify a couple of repos
Contributor
There was a problem hiding this comment.
Issue is we are changing the @main branch here, which almost all users are referencing.
So if that behaviour suddenly changes for people that haven't yet made the jump to the bazel lock stuff, it wouldn't be ideal I would say.
Member
There was a problem hiding this comment.
I've locked v0.0.0, maybe we should just start transitioning users?
Changes afer code review Signed-off-by: Dan Calavrezo <195309321+dcalavrezo-qorix@users.noreply.github.com>
AlexanderLanin
approved these changes
Mar 9, 2026
github-project-automation
bot
moved this from Draft
to Done
in INF - Infrastructure Community
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use lockfile error mode by default