Conversation
added support for running clippy checks Addresses: eclipse-score/score#2008 Signed-off-by: Dan Calavrezo <195309321+dcalavrezo-qorix@users.noreply.github.com>
dcalavrezo-qorix
requested review from
LittleHuba,
castler and
hoe-jo
as code owners
|
warnings/errors on the build job? |
Addresses: eclipse-score/score#2008 Signed-off-by: Dan Calavrezo <195309321+dcalavrezo-qorix@users.noreply.github.com>
pawelrutkaq
left a comment
pawelrutkaq
left a comment
There was a problem hiding this comment.
I have not looked into "old rust api".
| tags = ["manual"], | ||
| tags = [ | ||
| "manual", | ||
| "no-clippy", |
| srcs = ["ipc_bridge_gen.rs"], | ||
| visibility = [ | ||
| "//score/mw/com:__subpackages__", | ||
| "//visibility:public", |
There was a problem hiding this comment.
maybe the subpackages visibility shall be changed to public in module only ? I guess most of them shall not be public as such for external consumers.
Changed the visibility after PR review Signed-off-by: Dan Calavrezo <195309321+dcalavrezo-qorix@users.noreply.github.com>
LittleHuba
left a comment
LittleHuba
left a comment
There was a problem hiding this comment.
Please switch you approach to use rules_lint clippy instead.
This is the preferred way of integrating linters with bazel.
https://github.com/aspect-build/rules_lint/blob/79afc5ce25f55e918a93ef66ed81163423cdf632/example/tools/lint/linters.bzl#L6
|
Closing this PR since the implemented solution is not acceptable and an agreement was achieved on S-CORE project level to use rules_lint. |
4 participants
added support for running clippy checks
Addresses: eclipse-score/score#2008