mw/com: Add Requirements for the Method extension of Fields#174
Draft
gdadunashvili wants to merge 1 commit intoeclipse-score:mainfrom
Draft
mw/com: Add Requirements for the Method extension of Fields#174gdadunashvili wants to merge 1 commit intoeclipse-score:mainfrom
gdadunashvili wants to merge 1 commit intoeclipse-score:mainfrom
Conversation
gdadunashvili
requested review from
LittleHuba,
castler and
hoe-jo
as code owners
gdadunashvili
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
gdadunashvili
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
gdadunashvili
force-pushed
the
dadu_additional_requirements_for_fields
branch
from
b888aa4 to
e54d974
Compare
gdadunashvili
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
gdadunashvili
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
LittleHuba
force-pushed
the
dadu_additional_requirements_for_fields
branch
from
e54d974 to
30f7e7d
Compare
LittleHuba
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
LittleHuba
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
LittleHuba
had a problem deploying
to
workflow-approval
GitHub Actions
Failure
castler
force-pushed
the
dadu_additional_requirements_for_fields
branch
from
30f7e7d to
52bafd0
Compare
gdadunashvili
commented
Mar 17, 2026
| } | ||
|
|
||
| ScoreReq.CompReq GetMethodSignature { | ||
| description=""" The signature of the `Get` method shall be: `bmw::Result<MethodReturnTypePtr<SampleDataType>> Get()`.""" |
Member
Author
There was a problem hiding this comment.
Suggested change
| description=""" The signature of the `Get` method shall be: `bmw::Result<MethodReturnTypePtr<SampleDataType>> Get()`.""" | |
| description=""" The signature of the `Get` method shall be: `score::Result<MethodReturnTypePtr<SampleDataType>> Get()`.""" |
| } | ||
|
|
||
| ScoreReq.CompReq SetMethodSignature { | ||
| description=""" The signature of the `Set` method shall be: `bmw::Result<MethodReturnTypePtr<SampleDataType>> Set(MethodInArgPtr<SampleDataType>)`""" |
Member
Author
There was a problem hiding this comment.
Suggested change
| description=""" The signature of the `Set` method shall be: `bmw::Result<MethodReturnTypePtr<SampleDataType>> Set(MethodInArgPtr<SampleDataType>)`""" | |
| description=""" The signature of the `Set` method shall be: `score::Result<MethodReturnTypePtr<SampleDataType>> Set(MethodInArgPtr<SampleDataType>)`""" |
| } | ||
|
|
||
| ScoreReq.CompReq AllocateMethodSignature { | ||
| description="""The signature of the `Allocate()` method shall be: `bmw::Result<impl::MethodInArgPtr<SampleDataType>> Allocate()`.""" |
Member
Author
There was a problem hiding this comment.
Suggested change
| description="""The signature of the `Allocate()` method shall be: `bmw::Result<impl::MethodInArgPtr<SampleDataType>> Allocate()`.""" | |
| description="""The signature of the `Allocate()` method shall be: `score::Result<impl::MethodInArgPtr<SampleDataType>> Allocate()`.""" |
| } | ||
|
|
||
| ScoreReq.CompReq ZeroCopySetMethodSignature { | ||
| description="""The signature of the `Set` method shall be: `bmw::Result<MethodReturnTypePtr<SampleDataType>> Set(MethodInArgPtr<SampleDataType>)`""" |
Member
Author
There was a problem hiding this comment.
Suggested change
| description="""The signature of the `Set` method shall be: `bmw::Result<MethodReturnTypePtr<SampleDataType>> Set(MethodInArgPtr<SampleDataType>)`""" | |
| description="""The signature of the `Set` method shall be: `score::Result<MethodReturnTypePtr<SampleDataType>> Set(MethodInArgPtr<SampleDataType>)`""" |
|
|
||
|
|
||
| ScoreReq.CompReq RegisterGetHandlerSignature { | ||
| description=""" The signature of the `RegisterGetHandler` method shall be: `bmw::ResultBlank RegisterGetHandler(GetHandlerType)`""" |
Member
Author
There was a problem hiding this comment.
Suggested change
| description=""" The signature of the `RegisterGetHandler` method shall be: `bmw::ResultBlank RegisterGetHandler(GetHandlerType)`""" | |
| description=""" The signature of the `RegisterGetHandler` method shall be: `score::ResultBlank RegisterGetHandler(GetHandlerType)`""" |
Contributor
There was a problem hiding this comment.
In my view, the requirement for RegisterGetHandler on the Skeleton side is not needed. The RegisterGetHandler function will not be exposed to the user, as it is managed internally by LoLa. Therefore, it should be considered an implementation detail.
| } | ||
|
|
||
| ScoreReq.CompReq RegisterSetHandlerSignature { | ||
| description=""" The signature of the `RegisterSetHandler` method shall be: `bmw::ResultBlank RegisterSetHandler(SetHandlerType)`""" |
Member
Author
There was a problem hiding this comment.
Suggested change
| description=""" The signature of the `RegisterSetHandler` method shall be: `bmw::ResultBlank RegisterSetHandler(SetHandlerType)`""" | |
| description=""" The signature of the `RegisterSetHandler` method shall be: `score::ResultBlank RegisterSetHandler(SetHandlerType)`""" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: