Skip to content

Move bazel overrides in own file#103

Closed
ramceb wants to merge 4 commits intomainfrom
mb_cleanup_overrides
Closed

Move bazel overrides in own file#103
ramceb wants to merge 4 commits intomainfrom
mb_cleanup_overrides

Conversation

@ramceb
Copy link
Contributor

@ramceb ramceb commented Mar 4, 2026 •
edited
Loading

Fix cpp_lifecycle_app

@ramceb ramceb requested a deployment to workflow-approval March 4, 2026 10:54 — with GitHub Actions Waiting
@ramceb ramceb requested a deployment to workflow-approval March 4, 2026 10:54 — with GitHub Actions Waiting
@github-actions
Copy link

github-actions bot commented Mar 4, 2026 •
edited
Loading

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: 41f1facb-e71b-4ef1-91b9-1e0d8fcaec3d
Computing main repo mapping: 
ERROR: Error computing the main repository mapping: error reading '//:OVERRIDES.MODULE.bazel' included at /home/runner/work/lifecycle/lifecycle/MODULE.bazel:130:1: not a regular file

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

The created documentation from the pull request is available at: docu-html

@ramceb ramceb force-pushed the mb_cleanup_overrides branch from cb80a96 to 4a0f7ab Compare March 4, 2026 11:10
@ramceb ramceb requested a deployment to workflow-approval March 4, 2026 11:10 — with GitHub Actions Waiting
@ramceb ramceb requested a deployment to workflow-approval March 4, 2026 11:10 — with GitHub Actions Waiting
@ramceb
Cleanup bazel overrides
6cbff09 
Fix cpp_lifecycle_app
@ramceb ramceb force-pushed the mb_cleanup_overrides branch from 4a0f7ab to 6cbff09 Compare March 4, 2026 11:13
@ramceb ramceb temporarily deployed to workflow-approval March 4, 2026 11:13 — with GitHub Actions Inactive
@ramceb ramceb temporarily deployed to workflow-approval March 4, 2026 11:13 — with GitHub Actions Inactive
arkjedrz and others added 2 commits March 4, 2026 13:16
@arkjedrz @ramceb
repo: fix logging build issues
1b107bb 
- Change `baselibs` to `logging` module.
- Fix configuration in `.bazelrc`.
@ramceb
Fix dependency
64c6033
@ramceb ramceb requested a deployment to workflow-approval March 4, 2026 12:16 — with GitHub Actions Waiting
@ramceb ramceb requested a deployment to workflow-approval March 4, 2026 12:16 — with GitHub Actions Waiting
pawelrutkaq
pawelrutkaq requested changes Mar 4, 2026
View reviewed changes
DEV_OVERRIDES.MODULE.bazel
@@ -0,0 +1,37 @@
# *******************************************************************************
Copy link
Contributor

@pawelrutkaq pawelrutkaq Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need that change really? We dont have so big module file that this is issue

Copy link
Contributor Author

@ramceb ramceb Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should make it easier to enforce that we use git_overrides for development only.

MODULE.bazel

# this should be the last statement

include("//:OVERRIDES.MODULE.bazel")
Copy link
Contributor

@pawelrutkaq pawelrutkaq Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not allowed. This breaks usage of this module in another module or ? Only Root modules are allowed to include

Copy link
Contributor Author

@ramceb ramceb Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. you are right :-) it's not allowed. So for releases we should comment this out, because releases shall not contain git_overrides. git_overrides shall only be used for development. Anyhow it's convenient to have a OVERRIDES.MODULE.bazel for development.

@ramceb
Renaming of files
69f7128 
Rename OVERRIDES.MODULE.bazel to DEV_OVERRIDES.MODULE.bazel
@ramceb ramceb requested a deployment to workflow-approval March 4, 2026 14:40 — with GitHub Actions Waiting
@ramceb ramceb requested a deployment to workflow-approval March 4, 2026 14:40 — with GitHub Actions Waiting
@ramceb ramceb closed this Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pawelrutkaq pawelrutkaq pawelrutkaq requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ramceb @pawelrutkaq @arkjedrz