repo: fix logging build issues#104
Merged
ramceb merged 1 commit intoeclipse-score:mainfrom Mar 4, 2026
Merged
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
- Change `baselibs` to `logging` module. - Fix configuration in `.bazelrc`.
a6ca94a to
34a8f41
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates Bazel dependencies and configuration to resolve build issues caused by score::mw::log moving from the score_baselibs module into the dedicated score_logging module.
Changes:
- Replace
@score_baselibs//score/mw/logdependencies with@score_logging//score/mw/logacross affected BUILD targets. - Add
score_loggingtoMODULE.bazel(and a temporarytrlcoverride workaround) and updateMODULE.bazel.lockaccordingly. - Update
.bazelrcto pointKRemote_Loggingflag configuration at@score_logging.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/lifecycle_client_lib/BUILD | Switch logging deps from score_baselibs to score_logging. |
| src/launch_manager_daemon/process_state_client_lib/BUILD | Switch logging dep to score_logging. |
| src/launch_manager_daemon/lifecycle_client_lib/BUILD | Switch logging dep to score_logging. |
| src/launch_manager_daemon/health_monitor_lib/BUILD | Switch multiple logging deps to score_logging. |
| src/launch_manager_daemon/BUILD | Switch binary/library logging deps to score_logging. |
| src/control_client_lib/BUILD | Switch logging dep to score_logging. |
| MODULE.bazel | Add score_logging dependency and temporary trlc dev-dependency override. |
| MODULE.bazel.lock | Lockfile updates reflecting new module resolution graph. |
| .bazelrc | Update KRemote_Logging flag to use @score_logging label. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
The created documentation from the pull request is available at: docu-html |
ramceb
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
baselibstologgingmodule..bazelrc.