Skip to content

repo: fix logging build issues#104

Merged
ramceb merged 1 commit intoeclipse-score:mainfrom
qorix-group:arkjedrz_fix-logging-build
Mar 4, 2026
Merged

repo: fix logging build issues#104
ramceb merged 1 commit intoeclipse-score:mainfrom
qorix-group:arkjedrz_fix-logging-build

Conversation

@arkjedrz
Copy link
Contributor

@arkjedrz arkjedrz commented Mar 4, 2026

  • Change baselibs to logging module.
  • Fix configuration in .bazelrc.

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: b1fe23f4-5a81-4e6c-8a2f-e11d1cd1a030
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'score_rust_policies', the root module requires module version score_rust_policies@0.0.3, but got score_rust_policies@0.0.5 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (69 packages loaded, 9 targets configured)

Analyzing: target //:license-check (117 packages loaded, 44 targets configured)

Analyzing: target //:license-check (150 packages loaded, 2655 targets configured)

Analyzing: target //:license-check (154 packages loaded, 3805 targets configured)

Analyzing: target //:license-check (165 packages loaded, 7889 targets configured)

Analyzing: target //:license-check (165 packages loaded, 7901 targets configured)

Analyzing: target //:license-check (165 packages loaded, 7901 targets configured)

Analyzing: target //:license-check (165 packages loaded, 7901 targets configured)

Analyzing: target //:license-check (168 packages loaded, 9789 targets configured)

Analyzing: target //:license-check (169 packages loaded, 9913 targets configured)

INFO: Analyzed target //:license-check (170 packages loaded, 10039 targets configured).
[14 / 16] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 24.839s, Critical Path: 2.57s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

- Change `baselibs` to `logging` module.
- Fix configuration in `.bazelrc`.
@arkjedrz arkjedrz force-pushed the arkjedrz_fix-logging-build branch from a6ca94a to 34a8f41 Compare March 4, 2026 11:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Bazel dependencies and configuration to resolve build issues caused by score::mw::log moving from the score_baselibs module into the dedicated score_logging module.

Changes:

  • Replace @score_baselibs//score/mw/log dependencies with @score_logging//score/mw/log across affected BUILD targets.
  • Add score_logging to MODULE.bazel (and a temporary trlc override workaround) and update MODULE.bazel.lock accordingly.
  • Update .bazelrc to point KRemote_Logging flag configuration at @score_logging.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/lifecycle_client_lib/BUILD Switch logging deps from score_baselibs to score_logging.
src/launch_manager_daemon/process_state_client_lib/BUILD Switch logging dep to score_logging.
src/launch_manager_daemon/lifecycle_client_lib/BUILD Switch logging dep to score_logging.
src/launch_manager_daemon/health_monitor_lib/BUILD Switch multiple logging deps to score_logging.
src/launch_manager_daemon/BUILD Switch binary/library logging deps to score_logging.
src/control_client_lib/BUILD Switch logging dep to score_logging.
MODULE.bazel Add score_logging dependency and temporary trlc dev-dependency override.
MODULE.bazel.lock Lockfile updates reflecting new module resolution graph.
.bazelrc Update KRemote_Logging flag to use @score_logging label.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@arkjedrz arkjedrz temporarily deployed to workflow-approval March 4, 2026 11:33 — with GitHub Actions Inactive
@arkjedrz arkjedrz temporarily deployed to workflow-approval March 4, 2026 11:33 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

The created documentation from the pull request is available at: docu-html

@ramceb ramceb merged commit 1f3d327 into eclipse-score:main Mar 4, 2026
16 checks passed
@arkjedrz arkjedrz deleted the arkjedrz_fix-logging-build branch March 4, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants