-
Notifications
You must be signed in to change notification settings - Fork 3
Initial sanitizer configurations #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RSingh1511
wants to merge
16
commits into
eclipse-score:main
Choose a base branch
from
RSingh1511:rs/swp-245137
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
03330fd
Initial sanitizer configurations
RSingh1511 0074202
Add tests and CI workflow
RSingh1511 e54b31b
Address all PR review feedback
RSingh1511 b5133ac
Add PR and issue templates
RSingh1511 704598f
Address workflow review comments
RSingh1511 6f1128b
Add manual negative tests to verify sanitizers work
RSingh1511 f32f51e
Convert negative tests to automated sh_test with exit code validation
RSingh1511 6ad8f42
Fix BUILD.bazel issues per review feedback
RSingh1511 5f0d254
Address review comments: fix templates, change to copy pattern
RSingh1511 281f78d
Centralize runtime options using --run_under wrappers
RSingh1511 eaa6355
Address review comments
RSingh1511 cf027ca
Add centralized sanitizer infrastructure extracted from communication…
RSingh1511 309e43d
Remove coverage flag and fix TSan halt_on_error per review
RSingh1511 d6f8104
Address review feedback: simplify docs and fix tag filters
RSingh1511 7d2f594
Improve sanitizer configuration documentation
RSingh1511 07a78d6
Generalize TSan suppressions for Rust test runner
RSingh1511 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 8.3.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| name: Bugfix | ||
| about: 'Issue to track a bugfix' | ||
| title: 'Bugfix: Your bugfix title' | ||
| labels: 'codeowner_review' | ||
| assignees: '' | ||
|
|
||
| --- | ||
|
|
||
| > [!IMPORTANT] | ||
| > Make sure to link this issue with the PR for your bugfix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| --- | ||
| name: Bug report | ||
| about: Create a report for a bug | ||
| title: 'Bug: Your bug title' | ||
| labels: 'bug' | ||
| assignees: '' | ||
|
|
||
| --- | ||
|
|
||
| ### Describe the bug: | ||
| <!-- A clear and concise description of what the bug is. --> | ||
|
|
||
| ### Steps to reproduce the behavior: | ||
| 1. | ||
| 2. | ||
|
|
||
| ### Observed behavior: | ||
|
|
||
| ### Expected behavior: | ||
|
|
||
| ### Occurrence: | ||
| <!-- Sporadic / Always --> | ||
|
|
||
| ### Attachments / Logs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| name: Improvement | ||
| about: 'Issue to track a improvement' | ||
| title: 'Improvement: Your improvement title' | ||
| labels: 'codeowner_review' | ||
| assignees: '' | ||
|
|
||
| --- | ||
|
|
||
| > [!IMPORTANT] | ||
| > Make sure to link this issue with the PR for your improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # Bugfix | ||
|
|
||
| > [!IMPORTANT] | ||
| > Use this template only for bugfixes that do not influence topics covered by contribution requests or improvements. | ||
|
|
||
| > [!CAUTION] | ||
| > Make sure to submit your pull-request as **Draft** until you are ready to have it reviewed by the Committers. | ||
|
|
||
| ## Description | ||
|
|
||
| [A short description of the bug being fixed by the contribution.] | ||
|
|
||
| ## Related ticket | ||
|
|
||
| > [!IMPORTANT] | ||
| > Please replace `[ISSUE-NUMBER]` with the issue-number that tracks this bug fix. If there is no such | ||
| > ticket yet, create one via [this issue template](../ISSUE_TEMPLATE/new?template=bug_fix.md). | ||
|
|
||
| closes [ISSUE-NUMBER] (bugfix ticket) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # Improvement | ||
|
|
||
| > [!IMPORTANT] | ||
| > Use this template only for improvement that do not influence topics covered by contribution requests or bug fixes. | ||
|
|
||
| > [!CAUTION] | ||
| > Make sure to submit your pull-request as **Draft** until you are ready to have it reviewed by the Committers. | ||
|
|
||
| ## Description | ||
|
|
||
| [A short description of the improvement being addressed by the contribution.] | ||
|
|
||
| ## Related ticket | ||
|
|
||
| > [!IMPORTANT] | ||
| > Please replace `[ISSUE-NUMBER]` with the issue-number that tracks this bug fix. If there is no such | ||
| > ticket yet, create one via [this issue template](../ISSUE_TEMPLATE/new?template=improvement.md). | ||
|
|
||
| closes [ISSUE-NUMBER] (improvement ticket) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| <!-- markdownlint-disable MD013 Line breaks on the bullet list lines are also present on the github renderer, therefore no line length limitation --> | ||
| <!-- markdownlint-disable MD041 On the github PR template we want to start with '## Headline' --> | ||
|
|
||
| ## Notes for Reviewer | ||
| <!-- Items in addition to the checklist below that the reviewer should look for --> | ||
|
|
||
| ## Pre-Review Checklist for the PR Author | ||
|
|
||
| * [ ] PR title is short, expressive and meaningful | ||
| * [ ] Commits are properly organized | ||
| * [ ] Relevant issues are linked in the [References](#references) section | ||
| * [ ] Tests are conducted | ||
| * [ ] Unit tests are added | ||
|
|
||
| ## Checklist for the PR Reviewer | ||
|
|
||
| * [ ] Commits are properly organized and messages follow [S-CORE commit guidelines](https://eclipse-score.github.io/score/main/contribute/contribution_request/index.html) | ||
| * [ ] Unit tests have been written for new behavior | ||
| * [ ] Public API is documented | ||
| * [ ] PR title describes the changes | ||
|
|
||
| ## Post-review Checklist for the PR Author | ||
|
|
||
| * [ ] All open points are addressed and tracked via issues | ||
|
|
||
| ## References | ||
|
|
||
| <!-- Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue. --> | ||
|
|
||
| Closes # <!-- Add issue number after '#' --> | ||
|
|
||
| <!-- markdownlint-enable MD041 --> | ||
| <!-- markdownlint-enable MD013 --> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| # ******************************************************************************* | ||
| # Copyright (c) 2026 Contributors to the Eclipse Foundation | ||
| # | ||
| # See the NOTICE file(s) distributed with this work for additional | ||
| # information regarding copyright ownership. | ||
| # | ||
| # This program and the accompanying materials are made available under the | ||
| # terms of the Apache License Version 2.0 which is available at | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # ******************************************************************************* | ||
|
|
||
| name: Tests | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| test-sanitizers: | ||
| name: Test ${{ matrix.config }} | ||
| runs-on: ubuntu-24.04 | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| config: | ||
| - asan_ubsan_lsan | ||
| - tsan | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v6 | ||
|
|
||
| - name: Setup Bazel | ||
| uses: bazel-contrib/setup-bazel@0.18.0 | ||
| with: | ||
| bazelisk-cache: true | ||
| cache-save: ${{ github.event_name == 'push' }} | ||
|
|
||
| - name: Test with ${{ matrix.config }} | ||
| working-directory: tests | ||
| run: bazel test --config=${{ matrix.config }} //... --verbose_failures | ||
|
|
||
| - name: Upload test logs on failure | ||
| if: failure() | ||
| uses: actions/upload-artifact@v7 | ||
| with: | ||
| name: testlogs-${{ matrix.config }}-${{ github.run_id }} | ||
| path: tests/bazel-testlogs/**/test.log | ||
| if-no-files-found: ignore | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Bazel build outputs | ||
| bazel-* | ||
| .bazel-* | ||
|
|
||
| # IDE files | ||
| .vscode/ | ||
| .idea/ | ||
| *.swp | ||
| *.swo | ||
| *~ | ||
|
|
||
| # OS files | ||
| .DS_Store | ||
| Thumbs.db | ||
| *.lock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # ******************************************************************************* | ||
| # Copyright (c) 2026 Contributors to the Eclipse Foundation | ||
| # | ||
| # See the NOTICE file(s) distributed with this work for additional | ||
| # information regarding copyright ownership. | ||
| # | ||
| # This program and the accompanying materials are made available under the | ||
| # terms of the Apache License Version 2.0 which is available at | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # ******************************************************************************* | ||
|
|
||
| exports_files( | ||
| [ | ||
| "LICENSE.md", | ||
| "NOTICE", | ||
| ], | ||
| visibility = ["//visibility:public"], | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # score_cpp_policies Contribution Guide | ||
|
|
||
| The [Eclipse Safe Open Vehicle Core (S-CORE)](https://projects.eclipse.org/projects/automotive.score) project develops an open-source core stack for Software Defined Vehicles (SDVs). This repository centralizes the shared C++ quality tool policies (sanitizers, clang-tidy, clang-format) that S-CORE modules reuse to maintain consistent, safety-focused defaults. | ||
|
|
||
| Project communication happens via the [score-dev mailing list](https://accounts.eclipse.org/mailing-list/score-dev), GitHub issues and pull requests, and Slack. | ||
|
|
||
| Please note that the [Eclipse Foundation's Terms of Use](https://www.eclipse.org/legal/terms-of-use/) apply. Contributors must sign both the [ECA](https://www.eclipse.org/legal/ECA.php) and the [DCO](https://www.eclipse.org/legal/dco/). | ||
|
|
||
| ## Contributing changes | ||
|
|
||
| 1. Open an issue describing the policy change you propose (e.g., enabling/disabling a sanitizer option or clang-tidy rule) and the rationale, including links to any affected projects. | ||
| 2. Submit a PR referencing the issue. Keep changes minimal and well-documented, and include examples that justify the chosen defaults when possible. | ||
| 3. Request reviews from the S-CORE committers. Follow the commit message rules in the [Eclipse Foundation Project Handbook](https://www.eclipse.org/projects/handbook/#resources-commit). | ||
|
|
||
| If you are new to the project, see the S-CORE process descriptions and templates at [https://eclipse-score.github.io/score/process_description/](https://eclipse-score.github.io/score/process_description/). |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please limit permissions for security
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done