Set request limits for operator to ensure QOS Class#90
Open
Set request limits for operator to ensure QOS Class#90
Conversation
Signed-off-by: Simon Graband <sgraband@eclipsesource.com>
jfaltermeier
force-pushed
the
sg/operatorQOS
branch
from
80d86d5 to
357ae28
Compare
jfaltermeier
requested changes
Feb 28, 2025
Contributor
jfaltermeier
left a comment
jfaltermeier
left a comment
There was a problem hiding this comment.
Thanks! I have one comment. Also, just a heads-up that I rebased the changes.
| imagePullSecrets: | ||
| - name: {{ tpl (.Values.operator.imagePullSecret | toString) . }} | ||
| {{- end }} | ||
| requestsMemory: {{ tpl (.Values.operator.requestsMemory | toString) . }} |
Contributor
There was a problem hiding this comment.
Shouldn't this be similar to: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#example-1
So something like this?
resources:
requests:
memory: {{ tpl (.Values.operator.requestsMemory | toString) . }}
cpu: {{ tpl (.Values.operator.requestsCpu | toString) . }}
I also think the nesting level might be wrong, this should go under containers -> operator-container on the same level as image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.