Adding consumer for uSubscription service compatible with up-spec alpha4#305
Conversation
2dfc08b to
c1dcf6e
Compare
|
Code coverage report is ready! 📈
|
No, the errors from #307 are also fixed here (to look if it keeps failing despite fixing it). #307 resolved the linting errors. Here it is failing due to linting warnings. There are lots of warnings, so would it make sense to resolve all clang-tidy warnings in a separate issue and approve despite them? |
Okay, got it.
Sure, would you like to open an issue for resolving the warnings? Also -- I think this needs to be rebased, then we can spin the CI again and go for a merge. |
|
Code coverage report is ready! 📈
|
PLeVasseur
left a comment
There was a problem hiding this comment.
LGTM. Seems to be a cleanly opened version of #292 which went through code review already.
This PR reopens the PR #292. In addition, the Consumer is upgraded to the release alpha4 of the spec. The upgrade to alpha4 came with changes in the usubscription.proto .