Skip to content

Allow to distinguish between save and revert in editor callback #3488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mx990 wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −1
Open

Allow to distinguish between save and revert in editor callback #3488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions org.eclipse.xtext.ui/src/org/eclipse/xtext/ui/editor/CompoundXtextEditorCallback.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,17 @@ public void afterSave(XtextEditor xtextEditor) {
}
}

@Override
public void afterRevert(XtextEditor xtextEditor) {
for (IXtextEditorCallback xtextEditorCallback : editorCallbacks) {
try {
xtextEditorCallback.afterRevert(xtextEditor);
} catch (Exception e) {
handle(e);
}
}
}

@Override
public void beforeDispose(XtextEditor xtextEditor) {
for (IXtextEditorCallback xtextEditorCallback : editorCallbacks) {
Expand Down
4 changes: 4 additions & 0 deletions org.eclipse.xtext.ui/src/org/eclipse/xtext/ui/editor/IXtextEditorCallback.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ public interface IXtextEditorCallback {
*/
void afterSave(XtextEditor editor);

default void afterRevert(XtextEditor editor) {
afterSave(editor);
}

void beforeDispose(XtextEditor editor);

boolean onValidateEditorInputState(XtextEditor editor);
Expand Down
2 changes: 1 addition & 1 deletion org.eclipse.xtext.ui/src/org/eclipse/xtext/ui/editor/XtextEditor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ protected void run() throws Exception {
@Override
public void doRevertToSaved() {
super.doRevertToSaved();
callback.afterSave(this);
callback.afterRevert(this);
}

/**
Expand Down
Loading