Replace JUnit 5 with JUnit 6#3560
Merged
cdietrich merged 9 commits intoeclipse-xtext:mainfrom Mar 19, 2026
Merged
Conversation
Contributor
Author
|
There is a surprising number of JUnit 5 mentions, including even a quick fix action for adding JUnit 5 to the classpath... Probably for This PR so far doesn't touch any of those. |
Test Results 8 076 files + 4 8 076 suites +4 3h 40m 16s ⏱️ - 28m 36s For more details on these failures, see this check. Results for commit 84f8e29. ± Comparison against base commit 088392b. This pull request removes 17 and adds 17 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
trancexpress
force-pushed
the
gh3552
branch
2 times, most recently
from
2c93f7a to
ad11eb8
Compare
Contributor
Author
|
Running Fully summary: At least in JDT/PDE, this was usually an indicator of mixing JUnit 5 and 6 at runtime. It might be something else here. Such as JUnit 4 tests... Trying this: Results in: |
Contributor
|
maybe this is a way too old tycho? |
cdietrich
reviewed
Nov 19, 2025
Contributor
Author
Should I try updating to |
Contributor
|
see #3509 we had a brief discussion to look into that someone after the current release (building milestones and releases is actually already beyond my cappa) |
Contributor
|
the problem with tycho 5 is
what happens if use selects java 17 in wizard? should we have a fallback to old version. this also affecs junit 5/6 what should we offer the user. |
Contributor
|
can you also check Jenkinsfile |
Contributor
Author
|
With |
Contributor
Author
We can always delay the JUnit 6 update for when Advantest is not in a rush, since the workaround is trivial. |
Closed
Contributor
Author
|
Current errors: |
Contributor
Author
|
@cdietrich do we want also renames for bundles? If they have |
Contributor
|
yes you can also rename them |
…esting.junit6.tests
Contributor
|
can you check JUnitVersion enum and references @szarnekow @LorenzoBettini wdyt? |
Contributor
See my comments above. I seem to understand that the enum hasn't been changed. |
Contributor
|
i assume no user uses it. https://github.com/search?q=%22import+org.eclipse.xtext.util.JUnitVersion%22&type=code maybe we should mark it somehow |
Contributor
Author
|
Let me know what you decide for the JUnit 5 constant that is currently removed. Also if I'm missing any changes, I'm not sure what else to grep for. |
Contributor
|
then let remove the old constant, use the new one in the tests, wizard fragments etc |
trancexpress
changed the title
Contributor
Author
|
There are not many JUnit 5/6 tests to check if the move works: I ran all of these from Eclipse, there are no issues. What JUnit 4 tests I tried running also work as usual. |
Contributor
Author
|
Anything else to check here? |
cdietrich
reviewed
Mar 18, 2026
|
|
||
| <h2 id="testing">Unit Testing</h2> | ||
|
|
||
| <p>Automated tests are crucial for the maintainability and the quality of a software product. That is why it is strongly recommended to write unit tests for your language, too. The Xtext project wizard creates test projects for that purpose, which simplify the setup procedure for the basic language implementation as well as platform-specific integrations. It supports an option to either create your tests for JUnit 4 or JUnit 5. Depending on your choice your test layout will vary in some details.</p> |
Contributor
There was a problem hiding this comment.
this needs to be fixed in (https://github.com/eclipse-xtext/xtext-website) pr against main
Contributor
Author
There was a problem hiding this comment.
cdietrich
reviewed
Mar 18, 2026
| <unit id="junit-platform-suite-api" version="[1.0.0,2.0.0)"/> | ||
| <unit id="junit-platform-suite-commons" version="[1.0.0,2.0.0)"/> | ||
| <unit id="junit-vintage-engine" version="[5.0.0,6.0.0)"/> | ||
| <unit id="junit-jupiter-api" version="[6.0.0,7.0.0)"/> |
Contributor
There was a problem hiding this comment.
what about the other target platforms
Contributor
Author
There was a problem hiding this comment.
Which targets also need adjustment? Also xtext-r202603.target?
xtext-latest.target
xtext-r202512.target
xtext-r202603.target
Contributor
There was a problem hiding this comment.
otherwise it would compile / would it?
Contributor
There was a problem hiding this comment.
no idea why it did
https://ci.eclipse.org/xtext/job/xtext/job/PR-3560/9/consoleFull
maybe tycho pulls stuff anyway.
Contributor
|
looks like you missued this one 
|
Contributor
|
i also still see in mwe2 files did you run CliWizardIntegrationTest |
cdietrich
reviewed
Mar 18, 2026
| <unit id="junit-platform-suite-api" version="[1.0.0,2.0.0)"/> | ||
| <unit id="junit-platform-suite-commons" version="[1.0.0,2.0.0)"/> | ||
| <unit id="junit-vintage-engine" version="[5.0.0,6.0.0)"/> | ||
| <unit id="junit-jupiter-api" version="[6.0.0,7.0.0)"/> |
Contributor
There was a problem hiding this comment.
the build fails, but i dont know why. can you check
Contributor
Author
There was a problem hiding this comment.
junit-platform-runner some bundles are removed, like this one. I keep forgetting.
Contributor
There was a problem hiding this comment.
<p2:Requirement
xmi:version="2.0"
xmlns:xmi="http://www.omg.org/XMI"
xmlns:p2="http://www.eclipse.org/oomph/p2/1.0"
name="junit-platform-runner"
versionRange="[1.14.3,1.14.3]"/>
Contributor
Author
There was a problem hiding this comment.
https://docs.junit.org/6.0.0-M1/release-notes/
The junit-platform-runner module that provided the JUnit 4 based JUnitPlatform runner has been discontinued.
For junit-platform-suite-commons I'm not sure where the official mention was, see e.g.: https://medium.com/javarevisited/whats-new-in-junit-6-key-changes-and-improvements-551a84d7ed1f
The junit-platform-suite-commons module is now integrated into junit-platform-suite.
Note that one of the changes in JUnit 6 is to have version 6 in all the bundles, the junit-platform- ones included.
cdietrich
reviewed
Mar 18, 2026
xtext-r202512.target
Outdated
| <unit id="junit-platform-commons" version="[6.0.0,7.0.0)"/> | ||
| <unit id="junit-platform-engine" version="[6.0.0,7.0.0)"/> | ||
| <unit id="junit-platform-launcher" version="[6.0.0,7.0.0)"/> | ||
| <unit id="junit-platform-runner" version="[6.0.0,7.0.0)"/> |
There was a problem hiding this comment.
Pull request overview
This PR updates Xtext/Xtend build + tooling + wizard/test templates to switch the “modern JUnit” option from JUnit 5 to JUnit 6, including target-platform units, dependency BOM versions, and renamed test bundles/launch configs.
Changes:
- Update target definitions / manifests / BOM versions to JUnit 6 ranges and remove obsolete JUnit Platform units.
- Update wizards/generators (UI + CLI + templates) to generate JUnit 6-based projects and workflows.
- Rename and adjust test bundles and Xtend IDE quickfix/buildpath support from JUnit 5 to JUnit 6.
Reviewed changes
Copilot reviewed 70 out of 96 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| xtext-r202603.target | Update JUnit installable unit version ranges to JUnit 6. |
| xtext-r202512.target | Update JUnit installable unit version ranges to JUnit 6. |
| xtext-latest.target | Update JUnit installable unit version ranges to JUnit 6. |
| pom.xml | Rename excluded test artifacts to junit6 variants; update comments mentioning JUnit 6. |
| org.eclipse.xtext.xtext.wizard/xtend-gen/org/eclipse/xtext/xtext/wizard/TestProjectDescriptor.java | Update JUnit selection checks and P2/Maven dependency versions to JUnit 6. |
| org.eclipse.xtext.xtext.wizard/xtend-gen/org/eclipse/xtext/xtext/wizard/TargetPlatformProject.java | Update generated target content to JUnit 6 units/versions; remove some platform units. |
| org.eclipse.xtext.xtext.wizard/xtend-gen/org/eclipse/xtext/xtext/wizard/RuntimeProjectDescriptor.java | Switch workflow generation to treat the “modern JUnit” option as JUnit 6. |
| org.eclipse.xtext.xtext.wizard/src/org/eclipse/xtext/xtext/wizard/TestProjectDescriptor.xtend | Update wizard dependency generation to JUnit 6 versions and selection. |
| org.eclipse.xtext.xtext.wizard/src/org/eclipse/xtext/xtext/wizard/TargetPlatformProject.xtend | Update wizard target template to JUnit 6 units/versions. |
| org.eclipse.xtext.xtext.wizard/src/org/eclipse/xtext/xtext/wizard/RuntimeProjectDescriptor.xtend | Update workflow template to emit junitVersion = "6". |
| org.eclipse.xtext.xtext.wizard/src/org/eclipse/xtext/xtext/wizard/cli/CliProjectsCreatorMain.java | Change CLI default JUnit selection to JUnit 6. |
| org.eclipse.xtext.xtext.ui/src/org/eclipse/xtext/xtext/ui/wizard/project/AdvancedNewProjectPage.java | Update wizard UI radio button from JUnit 5 to JUnit 6. |
| org.eclipse.xtext.xtext.generator/xtend-gen/org/eclipse/xtext/xtext/generator/junit/JUnitFragment.java | Update generator logic to use JUNIT_6 branch for Jupiter annotations/assertions. |
| org.eclipse.xtext.xtext.generator/src/org/eclipse/xtext/xtext/generator/junit/JUnitFragment.xtend | Update generator templates to use JUNIT_6 for Jupiter-based stubs. |
| org.eclipse.xtext.util/src/org/eclipse/xtext/util/JUnitVersion.java | Replace JUNIT_5 enum value with JUNIT_6 and update parsing. |
| org.eclipse.xtext.ui.testing/META-INF/MANIFEST.MF | Update optional Jupiter import range to JUnit 6. |
| org.eclipse.xtext.tests/testdata/wizard-expectations/mavenTychoJUnit6/mavenTychoJUnit6.parent/pom.xml | Rename wizard expectation project coordinates/modules from JUnit 5 to JUnit 6 variant. |
| org.eclipse.xtext.tests/testdata/wizard-expectations/mavenTychoJUnit6/mavenTychoJUnit6.parent/mavenTychoJUnit6/src/mydsl/MyDsl.xtext | Add expected grammar file for mavenTychoJUnit6 fixture. |
| org.eclipse.xtext.tests/testdata/wizard-expectations/mavenTychoJUnit6/mavenTychoJUnit6.parent/mavenTychoJUnit6/src/mydsl/GenerateMyDsl.mwe2 | Update expected baseName and junitVersion to “6”. |
| org.eclipse.xtext.tests/testdata/wizard-expectations/mavenTychoJUnit6/mavenTychoJUnit6.parent/mavenTychoJUnit6/pom.xml | Rename artifactId and src-gen copy paths for mavenTychoJUnit6 fixture. |
| org.eclipse.xtext.tests/testdata/wizard-expectations/mavenTychoJUnit6/mavenTychoJUnit6.parent/mavenTychoJUnit6/META-INF/MANIFEST.MF | Rename bundle metadata for mavenTychoJUnit6 fixture. |
| org.eclipse.xtext.tests/testdata/wizard-expectations/mavenTychoJUnit6/mavenTychoJUnit6.parent/mavenTychoJUnit6/build.properties | Add expected build.properties for mavenTychoJUnit6 fixture. |
| org.eclipse.xtext.tests/testdata/wizard-expectations/mavenTychoJUnit6/mavenTychoJUnit6.parent/mavenTychoJUnit6.web/pom.xml | Rename web module artifact/dependencies to mavenTychoJUnit6. |
| org.eclipse.xtext.tests/testdata/wizard-expectations/mavenTychoJUnit6/mavenTychoJUnit6.parent/mavenTychoJUnit6.ui/pom.xml | Rename UI module artifactId to mavenTychoJUnit6.ui. |
| org.eclipse.xtext.tests/testdata/wizard-expectations/mavenTychoJUnit6/mavenTychoJUnit6.parent/mavenTychoJUnit6.ui/META-INF/MANIFEST.MF | Rename UI bundle metadata and Require-Bundle entries to junit6 variant. |
| org.eclipse.xtext.tests/testdata/wizard-expectations/mavenTychoJUnit6/mavenTychoJUnit6.parent/mavenTychoJUnit6.ui/build.properties | Add expected UI build.properties for junit6 fixture. |
| org.eclipse.xtext.tests/testdata/wizard-expectations/mavenTychoJUnit6/mavenTychoJUnit6.parent/mavenTychoJUnit6.ui.tests/pom.xml | Rename UI test plugin artifactId to junit6 variant. |
| org.eclipse.xtext.tests/testdata/wizard-expectations/mavenTychoJUnit6/mavenTychoJUnit6.parent/mavenTychoJUnit6.ui.tests/META-INF/MANIFEST.MF | Update UI tests bundle metadata and Jupiter import ranges to JUnit 6. |
| org.eclipse.xtext.tests/testdata/wizard-expectations/mavenTychoJUnit6/mavenTychoJUnit6.parent/mavenTychoJUnit6.ui.tests/build.properties | Add expected UI tests build.properties for junit6 fixture. |
| org.eclipse.xtext.tests/testdata/wizard-expectations/mavenTychoJUnit6/mavenTychoJUnit6.parent/mavenTychoJUnit6.tests/pom.xml | Rename runtime tests plugin artifactId to junit6 variant. |
| org.eclipse.xtext.tests/testdata/wizard-expectations/mavenTychoJUnit6/mavenTychoJUnit6.parent/mavenTychoJUnit6.tests/META-INF/MANIFEST.MF | Add expected runtime tests MANIFEST for junit6 fixture. |
| org.eclipse.xtext.tests/testdata/wizard-expectations/mavenTychoJUnit6/mavenTychoJUnit6.parent/mavenTychoJUnit6.tests/build.properties | Add expected runtime tests build.properties for junit6 fixture. |
| org.eclipse.xtext.tests/testdata/wizard-expectations/mavenTychoJUnit6/mavenTychoJUnit6.parent/mavenTychoJUnit6.target/pom.xml | Rename target module artifactId to junit6 variant. |
| org.eclipse.xtext.tests/testdata/wizard-expectations/mavenTychoJUnit6/mavenTychoJUnit6.parent/mavenTychoJUnit6.target/mavenTychoJUnit6.target.target | Rename target name and update contained JUnit IUs/ranges to JUnit 6. |
| org.eclipse.xtext.tests/testdata/wizard-expectations/mavenTychoJUnit6/mavenTychoJUnit6.parent/mavenTychoJUnit6.ide/pom.xml | Rename IDE module artifactId to junit6 variant. |
| org.eclipse.xtext.tests/testdata/wizard-expectations/mavenTychoJUnit6/mavenTychoJUnit6.parent/mavenTychoJUnit6.ide/META-INF/MANIFEST.MF | Rename IDE bundle metadata/requirements to junit6 variant. |
| org.eclipse.xtext.tests/testdata/wizard-expectations/mavenTychoJUnit6/mavenTychoJUnit6.parent/mavenTychoJUnit6.ide/build.properties | Add expected IDE build.properties for junit6 fixture. |
| org.eclipse.xtext.tests/testdata/wizard-expectations/mavenTychoJUnit5/mavenTychoJUnit5.parent/mavenTychoJUnit5.tests/META-INF/MANIFEST.MF | Remove the junit5 fixture runtime tests MANIFEST. |
| org.eclipse.xtext.tests/testdata/wizard-expectations/gradle/gradle.parent/gradle/src/main/java/mydsl/GenerateMyDsl.mwe2 | Update expected junitVersion to “6” for gradle fixture. |
| org.eclipse.xtext.tests/src/org/eclipse/xtext/xtext/wizard/cli/CliWizardIntegrationTest.java | Update CLI wizard integration test to use baseName junit6 + JUNIT_6. |
| org.eclipse.xtext.tests/pom.xml | Update comment to reference forcing JUnit 6. |
| org.eclipse.xtext.testing/src/org/eclipse/xtext/testing/extensions/InjectionExtension.java | Update Javadoc references from JUnit 5 to JUnit 6. |
| org.eclipse.xtext.testing/src/org/eclipse/xtext/testing/AbstractXtextTests.java | Update Javadoc references from JUnit 5 to JUnit 6. |
| org.eclipse.xtext.testing/META-INF/MANIFEST.MF | Update Jupiter/platform import ranges to JUnit 6. |
| org.eclipse.xtext.testing.tests/src/org/eclipse/xtext/testing/tests/AbstractJUnitIntegrationTest.java | Update Javadoc reference from JUnit 5 to JUnit 6. |
| org.eclipse.xtext.testing.junit6.tests/src/org/eclipse/xtext/testing/tests/junit6/InjectionExtensionTest.java | Move tests to junit6 package namespace. |
| org.eclipse.xtext.testing.junit6.tests/src/org/eclipse/xtext/testing/tests/junit6/InjectionExtensionStaticInnerClassesTest.java | Move tests to junit6 package namespace. |
| org.eclipse.xtext.testing.junit6.tests/src/org/eclipse/xtext/testing/tests/junit6/InjectionExtensionNestedTest.java | Move tests to junit6 package namespace. |
| org.eclipse.xtext.testing.junit6.tests/src/org/eclipse/xtext/testing/tests/junit6/InjectionExtensionNested3Test.java | Move tests to junit6 package namespace. |
| org.eclipse.xtext.testing.junit6.tests/src/org/eclipse/xtext/testing/tests/junit6/InjectionExtensionNested2Test.java | Move tests to junit6 package namespace. |
| org.eclipse.xtext.testing.junit6.tests/src/org/eclipse/xtext/testing/tests/junit6/ComposedInjectAnnotationTest.java | Move tests to junit6 package namespace. |
| org.eclipse.xtext.testing.junit6.tests/src/org/eclipse/xtext/testing/tests/junit6/ComposedInject.java | Move helper annotation to junit6 package namespace. |
| org.eclipse.xtext.testing.junit6.tests/src/org/eclipse/xtext/testing/tests/junit6/AbstractJUnitIntegrationTest.java | Move base test class and update Javadoc to JUnit 6. |
| org.eclipse.xtext.testing.junit6.tests/pom.xml | Rename artifactId/name/comments to junit6 tests. |
| org.eclipse.xtext.testing.junit6.tests/org.eclipse.xtext.testing.junit6.tests.launch | Update Eclipse launch config to junit6 project/test kind ids. |
| org.eclipse.xtext.testing.junit6.tests/META-INF/MANIFEST.MF | Rename bundle symbolic name + update Jupiter/platform import ranges to JUnit 6. |
| org.eclipse.xtext.testing.junit6.tests/build.properties | Add PDE build properties for new/renamed bundle. |
| org.eclipse.xtext.testing.junit6.tests/about.html | Add about.html for junit6 tests bundle. |
| org.eclipse.xtext.testing.junit6.tests/.settings/org.eclipse.xtend.core.Xtend.prefs | Add Eclipse Xtend project settings for junit6 tests bundle. |
| org.eclipse.xtext.testing.junit6.tests/.settings/org.eclipse.m2e.core.prefs | Add Eclipse m2e settings for junit6 tests bundle. |
| org.eclipse.xtext.testing.junit6.tests/.settings/org.eclipse.jdt.ui.prefs | Add Eclipse JDT UI prefs for junit6 tests bundle. |
| org.eclipse.xtext.testing.junit6.tests/.settings/org.eclipse.jdt.core.prefs | Add Java 21 compiler prefs for junit6 tests bundle. |
| org.eclipse.xtext.testing.junit6.tests/.settings/org.eclipse.core.resources.prefs | Add project encoding prefs for junit6 tests bundle. |
| org.eclipse.xtext.testing.junit6.tests/.project | Rename Eclipse project to junit6 tests bundle. |
| org.eclipse.xtext.testing.junit6.tests/.classpath | Add Eclipse classpath entries for junit6 tests bundle. |
| org.eclipse.xtext.junit6.tests/xtext.junit6.tests.launch | Update Eclipse launch config to junit6 project/test kind ids. |
| org.eclipse.xtext.junit6.tests/src/org/eclipse/xtext/validation/junit6/FileAwareTestLanguageValidationJunit6Test.java | Move validation test to junit6 package/class naming. |
| org.eclipse.xtext.junit6.tests/src/log4j.properties | Add log4j config for junit6 test bundle. |
| org.eclipse.xtext.junit6.tests/pom.xml | Rename artifactId/name/description; update Tycho provider hint to junit6. |
| org.eclipse.xtext.junit6.tests/plugin.properties | Update pluginName string to “JUnit 6”. |
| org.eclipse.xtext.junit6.tests/META-INF/MANIFEST.MF | Rename bundle symbolic name and update Jupiter/platform import ranges to JUnit 6. |
| org.eclipse.xtext.junit6.tests/build.properties | Add PDE build properties for junit6 test bundle. |
| org.eclipse.xtext.junit6.tests/about.html | Add about.html for junit6 test bundle. |
| org.eclipse.xtext.junit6.tests/.settings/org.eclipse.xtend.core.Xtend.prefs | Add Xtend settings for junit6 test bundle. |
| org.eclipse.xtext.junit6.tests/.settings/org.eclipse.pde.prefs | Add PDE compiler settings for junit6 test bundle. |
| org.eclipse.xtext.junit6.tests/.settings/org.eclipse.m2e.core.prefs | Add m2e settings for junit6 test bundle. |
| org.eclipse.xtext.junit6.tests/.settings/org.eclipse.jdt.ui.prefs | Add JDT UI preferences for junit6 test bundle. |
| org.eclipse.xtext.junit6.tests/.settings/org.eclipse.jdt.launching.prefs | Add JDT launching prefs for junit6 test bundle. |
| org.eclipse.xtext.junit6.tests/.settings/org.eclipse.jdt.core.prefs | Add Java 21 compiler prefs for junit6 test bundle. |
| org.eclipse.xtext.junit6.tests/.settings/org.eclipse.core.resources.prefs | Add project encoding prefs for junit6 test bundle. |
| org.eclipse.xtext.junit6.tests/.project | Rename Eclipse project to junit6 test bundle. |
| org.eclipse.xtext.junit6.tests/.gitignore | Add gitignore rules for junit6 test bundle. |
| org.eclipse.xtext.junit6.tests/.classpath | Add Eclipse classpath entries for junit6 test bundle. |
| org.eclipse.xtext.full.releng/pom.xml | Switch releng module list from junit5 test bundles to junit6. |
| org.eclipse.xtext.doc/contents/303_runtime_concepts.html | Update docs from JUnit 5 wording to JUnit 6 wording. |
| org.eclipse.xtext.doc/contents/103_domainmodelnextsteps.html | Update docs note from JUnit 5 to JUnit 6. |
| org.eclipse.xtext.dev-bom/pom.xml | Bump junit-jupiter/junit-platform versions to 6.0.1; remove junit-platform-runner dependency. |
| org.eclipse.xtend.ide/src/org/eclipse/xtend/ide/quickfix/XtendQuickfixProvider.java | Update quickfix to add JUnit 6 libs/container instead of JUnit 5. |
| org.eclipse.xtend.ide/src/org/eclipse/xtend/ide/buildpath/Junit6LibClasspathAdder.java | Rename/add JUnit 6 classpath adder with updated container path and import ranges. |
| org.eclipse.xtend.ide.tests/xtend-gen/org/eclipse/xtend/ide/tests/quickfix/AddJunitLibToClasspathQuickfixTest.java | Update generated test expectations to JUnit 6 quickfix label/imports/container. |
| org.eclipse.xtend.ide.tests/xtend-gen/org/eclipse/xtend/ide/tests/buildpath/JunitLibClasspathAdderTest.java | Update generated buildpath tests to use Junit6LibClasspathAdder. |
| org.eclipse.xtend.ide.tests/src/org/eclipse/xtend/ide/tests/buildpath/JunitLibClasspathAdderTest.xtend | Update source buildpath tests to JUnit 6 lib adder and messages. |
| org.eclipse.xtend.ide.tests/longrunning/src/org/eclipse/xtend/ide/tests/quickfix/AddJunitLibToClasspathQuickfixTest.xtend | Update longrunning quickfix tests for JUnit 6 quickfix label/imports/container. |
| org.eclipse.xtend.core/src/org/eclipse/xtend/core/validation/XtendValidator.java | Rename comment section label from “JUnit5 annotations” to “JUnit6 annotations”. |
Comments suppressed due to low confidence (3)
org.eclipse.xtext.testing.junit6.tests/META-INF/MANIFEST.MF:26
Automatic-Module-Nameis still set toorg.eclipse.xtext.testing, which duplicates the mainorg.eclipse.xtext.testingbundle’s module name. Since this bundle was renamed toorg.eclipse.xtext.testing.junit6.tests, the module name should be updated accordingly to avoid JPMS module-name clashes.
org.eclipse.xtext.testing.junit6.tests/pom.xml:14- The Maven project
<name>uses "Junit" casing. For consistency with the rest of the repo and the common spelling, this should be "JUnit".
org.eclipse.xtext.testing.junit6.tests/META-INF/MANIFEST.MF:3 - The bundle name uses "Junit" casing. Consider changing it to "JUnit" for consistent spelling (e.g., "Xtext Testing Infrastructure JUnit 6 tests").
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Failures in the Windows build are: |
Contributor
cdietrich
reviewed
Mar 18, 2026
| org.junit.jupiter.params;version="[6.0.0,7.0.0)", | ||
| org.junit.jupiter.params.provider;version="[6.0.0,7.0.0)", | ||
| org.junit.platform.commons.support;version="[6.0.0,7.0.0)" | ||
| Automatic-Module-Name: org.eclipse.xtext.tests |
Contributor
There was a problem hiding this comment.
@trancexpress can check this one (also in others)
might be historically bad
Contributor
There was a problem hiding this comment.
@LorenzoBettini do you rember this was intentional=
Contributor
Author
There was a problem hiding this comment.
can check this one (also in others) might be historically bad
Please explain what should be checked and why.
Contributor
There was a problem hiding this comment.
Automatic-Module-Name: org.eclipse.xtext.tests seems wrong for the bundle name
Contributor
There was a problem hiding this comment.
@LorenzoBettini do you rember this was intentional=
That's for parameterized tests, IIRC.
I don't remember whether we have any parameterized tests; if not, I'd say it could be removed.
Contributor
There was a problem hiding this comment.
It was added when Eclipse started to complain about the missing module name. Back then, that check was enabled by default, while now it is not anymore.
When that project was created it was probably done with a copy and paste and that value was not updated. Either we update it or remove it. I think all the other projects have that, so it might be worthwhile to update it accordingly.
Contributor
Author
There was a problem hiding this comment.
Please move this discussion to a separate ticket, I don't see how it relates to this one.
Contributor
There was a problem hiding this comment.
Can’t we for now just copycthe bundle name to automated module named
Contributor
Author
There was a problem hiding this comment.
The PR is already massive, best to keep it focused only on the JUnit 6 change.
Contributor
Author
This is a lot of tests to be looking at, I checked only: Adding a bit of waiting here: I see frequent (though not always) fails: The stack traces are: This doesn't help: I'll keep looking, I assume something is running in parallel and expecting the indexer results sooner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #3552