Fixes and new vars from cads-obs-catalogue-manager tables version.#1
Merged
Fixes and new vars from cads-obs-catalogue-manager tables version.#1
Conversation
|
From my point of view the changes are ok. The changes should, however, be at least forwarded to the CDM-obs governance board to approve them. Ideally the data providers should send the requests to the governance board, not so much the CADS developers. |
Collaborator
Author
I am opening another PR to the base repository master, maybe you can write them an email to inform them about the changes? This is the PR: glamod/common_data_model#29 |
EddyCMWF
approved these changes
Apr 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.