Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #48 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 2 -2
Lines 73 10 -63
Branches 9 0 -9
=========================================
- Hits 73 10 -63 ☔ View full report in Codecov by Sentry. |
viktree
requested review from
aujlaramandeep27,
chriscsq,
ddamico-ecobee and
jessicawoo
arvinsingla
left a comment
arvinsingla
left a comment
There was a problem hiding this comment.
Just a couple comments. Feels like old times 😛
| "peerDependencies": { | ||
| "@nestjs/common": "^7.4.0 || ^8.1.2", | ||
| "@nestjs/microservices": "^7.4.0 || ^8.1.2" | ||
| "@nestjs/common": "^7.4.0 || ^8.1.2 || ^10.3.3", |
There was a problem hiding this comment.
If you're adding support for 10 should 9 also be added to ensure users with 9 can also leverage the lib?
There was a problem hiding this comment.
We have an immediate need to get it working with nest 10. I don't see why this couldn't work with nest 9, but I don't know what the compatible versions are of each of the dependencies.
If you have a specific version of nest 9 you want to use this with, I can test against it to be sure
| @@ -0,0 +1,18 @@ | |||
| name: Node.js CI | |||
There was a problem hiding this comment.
Is deploy also going to be moved to github actions or is that still going to be done in Circle?
There was a problem hiding this comment.
Uhhh eventually, maybe 😅. Some sort of company mandate since GitHub actions is cheaper for the company than CircleCi
viktree
force-pushed
the
upgrade-node-nest
branch
from
a9dfc31 to
6d6a500
Compare
Wiz Scan Summary
|
5 participants
See code changes