Conversation
|
@dmocek - you are getting a DCO failure because your commits don't have a flag to certificate of origin. See https://wiki.edgexfoundry.org/display/FA/Contributor%27s+Guide#Contributor'sGuide-SubmissionDCO You just need to add a "-s" flag to your commit requests (ex: git commit -s -m "feat:my commit message"). It is also failing on Semantic PR labeling. In your commit message, you need to specify that this is new feature, bug fix, etc. In this case, it would be a feature (feat). So use "feat" in your commit message as I did in my example above. See https://github.com/edgexfoundry/edgex-docs/blob/main/.github/semantic.yml for the allowed options. |
|
@dmocek . you also need to add this UCR to the UCR TOC here: https://docs.edgexfoundry.org/3.1/design/TOC/ |
|
Added to TOC. |
dmocek
force-pushed
the
device-functions
branch
from
d497da4 to
f662b12
Compare
Signed-off-by: Darryl Mocek <darryl.mocek@oracle.com>
Signed-off-by: Darryl Mocek <darryl.mocek@oracle.com>
Signed-off-by: Darryl Mocek <darryl.mocek@oracle.com>
Signed-off-by: Darryl Mocek <darryl.mocek@oracle.com>
Signed-off-by: Darryl Mocek <darryl.mocek@oracle.com>
Signed-off-by: Darryl Mocek <darryl.mocek@oracle.com>
Signed-off-by: Darryl Mocek <darryl.mocek@oracle.com>
dmocek
force-pushed
the
device-functions
branch
from
f662b12 to
903f261
Compare
Signed-off-by: Darryl Mocek <darryl.mocek@oracle.com>
|
All issues have been fixed. |
| EdgeX supports setting attributes on a device. The workaround for calling device functions currently in EdgeX is to configure a device to call a function when setting at attribute, which isn't always feasible. For example, to call a 'reboot' device function on a device, a 'reboot' attribute would have to be created and it would have to be set to a value to invoke the reboot function on the device. | ||
|
|
||
| ## Requirements | ||
| Each Device should have a function resource and its parameters defined to support calling the device function with appropriate parameters. |
There was a problem hiding this comment.
| Each Device should have a function resource and its parameters defined to support calling the device function with appropriate parameters. | |
| - Device Profiles shall have function resources which includes parameters defined to support calling the device function(s) with appropriate parameters. | |
| - A new `Call` Command type shall be created to support calling the new function resources. |
cloudxxx8
left a comment
cloudxxx8
left a comment
There was a problem hiding this comment.
The use case looks good to me
4 participants
Add Device Functions UCR.