Skip to content

fix: don't apply charset on document opening#466

Merged
SunsetTechuila merged 1 commit intomainfrom
encoding-this
Jan 22, 2026
Merged

fix: don't apply charset on document opening#466
SunsetTechuila merged 1 commit intomainfrom
encoding-this

Conversation

@SunsetTechuila
Copy link
Member

fixes #465

I see only two ways to trigger the didOpenTextDocument event without also triggering didChangeActiveTextEditor:

  • change language mode
  • change encoding

In neither of those cases do we need to apply charset

Please fill in this template.

  • Use a meaningful title for the pull request.
  • Use meaningful commit messages.
  • Run tsc w/o errors (same as npm run build).
  • Run npm run lint w/o errors.

@SunsetTechuila SunsetTechuila merged commit 09fdbff into main Jan 22, 2026
3 checks passed
@SunsetTechuila SunsetTechuila deleted the encoding-this branch January 22, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of undefined (reading 'onBeforeResolve')

1 participant