Skip to content

https://github.com/minkphp/MinkSelenium2Driver/pull/302 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edosenseidotcom wants to merge 4 commits into
base: master
Choose a base branch
from
Open

https://github.com/minkphp/MinkSelenium2Driver/pull/302 #1

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b57c052
https://github.com/minkphp/MinkSelenium2Driver/pull/302
edosenseidotcom Jun 11, 2022
f2a3755
do not overwrite existing values
edosenseidotcom Jun 11, 2022
c99bf8e
refactor so that sendKeys does not inappropriately replace the value
edosenseidotcom Jun 11, 2022
3134c0c
Merge branch 'master' into sendkeys
edosenseidotcom May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 33 additions & 4 deletions src/Selenium2Driver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,14 +668,12 @@ public function setValue(string $xpath, $value)
throw new DriverException(sprintf('Only string values can be used for a %s element.', $elementName));
}

$value = strval($value);

if (in_array($elementName, array('input', 'textarea'))) {
$existingValueLength = strlen($element->attribute('value'));
$value = str_repeat(Key::BACKSPACE . Key::DELETE, $existingValueLength) . $value;
$value = str_repeat(Key::BACKSPACE . Key::DELETE, $existingValueLength) . strval($value);
}

$element->postValue(array('value' => array($value)));
$this->postElementValue($value, $element);
// Remove the focus from the element if the field still has focus in
// order to trigger the change event. By doing this instead of simply
// triggering the change event for the given xpath we ensure that the
Expand All @@ -700,6 +698,28 @@ public function setValue(string $xpath, $value)
}
}

/**
* {@inheritdoc}
*/
public function sendKeys($xpath, $value)
{
$element = $this->findElement($xpath);
$elementName = strtolower($element->name());

if ('input' === $elementName) {
$elementType = strtolower($element->attribute('type'));

if (in_array($elementType, array('submit', 'image', 'button', 'reset', 'checkbox', 'radio', 'file'))) {
throw new DriverException(sprintf('Impossible to send keys on element with XPath "%s" as it is not a textbox', $xpath));
}
}

$this->postElementValue($value, $element);
}

/**
* {@inheritdoc}
*/
public function check(string $xpath)
{
$element = $this->findElement($xpath);
Expand Down Expand Up @@ -1154,4 +1174,13 @@ private function uploadFile(string $path): string

return $remotePath;
}

/**
* @param string $value the value of the element
* @param Element $element the webdriver element
*/
private function postElementValue($value, $element)
{
$element->postValue(array('value' => array($value)));
}
}