Fix for https://github.com/eduardoRoth/media-player/issues/72: Fix lo…#73
Open
flexgrip wants to merge 1 commit intoeduardoRoth:mainfrom
Open
Fix for https://github.com/eduardoRoth/media-player/issues/72: Fix lo…#73flexgrip wants to merge 1 commit intoeduardoRoth:mainfrom
flexgrip wants to merge 1 commit intoeduardoRoth:mainfrom
Conversation
…blocking play button in iOS
Author
|
I probably should have asked if this was even relevant, since you mentioned you were close to being done with v5.0? Anyway, just wanted to chip in. Thanks! |
eduardoRoth
requested changes
Apr 28, 2025
Owner
eduardoRoth
left a comment
eduardoRoth
left a comment
There was a problem hiding this comment.
@flexgrip thank you for this PR!!! I appreciate all the help I can get on this plugin 😄
Just a minor change, could you extract this code to another function, like "setAudioOnlyObservers" or something like that? Just so we keep that function small and have this logic outside
Owner
|
@flexgrip BTW, sorry about the late reply, I've had a lot going and haven't had the time to work on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72 "Loading animation covers play button with mp3's on iOS"
isAudioOnlymethod in MediaPlayerController.swift