Skip to content

Conversation

@mengfei0053
Copy link

@mengfei0053 mengfei0053 commented Feb 24, 2021

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #24 (b97f883) into master (c4326d2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #24   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines            9         9           
=========================================
  Hits             9         9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4326d2...60e7551. Read the comment docs.

@Runtu4378
Copy link

@atian25 大锅,你看这个pr可以合并了吗?最近用到 validator + ts 也遇到了类型提示不明显的情况,利用声明合并怎么都覆盖不了插件里面的类型声明,可能还是从源头上加上类型定义比较好解决一点。

image

@OnlyFlyer
Copy link

返回值建议还是取 Parameter.ValidateError[] 而不是 void ,当校验通过后返回的类型是 Parameter.ValidateError[],失败直接抛错也不会执行到后续的代码,void 没有意义。

image

@kerryChen95
Copy link

我也遇到了覆盖不了插件中的*.d.ts声明的问题,希望早日Merge这个PR

@andyFang94
Copy link

我也遇到了覆盖不了插件中的*.d.ts声明的问题,希望早日Merge这个PR

直接用parameter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants